Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

No previews for images uploaded from certain Samsung phones #555

Open
M4tthewDE opened this issue Nov 19, 2023 · 1 comment
Open

No previews for images uploaded from certain Samsung phones #555

M4tthewDE opened this issue Nov 19, 2023 · 1 comment
Labels
blocked Something out of our power needs to change before proceeding with this issue

Comments

@M4tthewDE
Copy link
Contributor

M4tthewDE commented Nov 19, 2023 •
edited
Loading

Certain Samsung phones produce invalid JPEG files, which causes libvips to throw an error.
Example image:
https://kappa.lol/ZEhuj

Newer versions of libvips seem to work around this issue, see lovell/sharp#1578 for more information.
Govips does not support this workaround as of yet, and returns an error as can be seen in davidbyttow/govips#348.

We should update govips as soon as there is a fix available to support these images.
@pajlada pajlada added the blocked Something out of our power needs to change before proceeding with this issue label Nov 19, 2023
@n0vad3v
Copy link

n0vad3v commented Mar 18, 2024

govips can use FailOnError to work around this, I've added a PoC here: davidbyttow/govips#348 (comment) here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
blocked Something out of our power needs to change before proceeding with this issue
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@pajlada @n0vad3v @M4tthewDE