From 05271d2678a2a4fb1f3de41ee089bade75b746ee Mon Sep 17 00:00:00 2001
From: didinele <didinele.dev@gmail.com>
Date: Fri, 19 Jul 2024 21:13:37 +0300
Subject: [PATCH] fix(purge): proper url check for attachments

---
 services/interactions/src/handlers/mod.ts   | 2 +-
 services/interactions/src/handlers/purge.ts | 4 ++--
 2 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/services/interactions/src/handlers/mod.ts b/services/interactions/src/handlers/mod.ts
index ad2ba4d8..d6313827 100644
--- a/services/interactions/src/handlers/mod.ts
+++ b/services/interactions/src/handlers/mod.ts
@@ -113,7 +113,7 @@ export default class ModHandler implements HandlerModule<CoralInteractionHandler
 					description: 'Ban a user',
 					options: baseOptionsWith({
 						name: 'cleanup',
-						description: "Delete the user's recent messages",
+						description: "Specify how far back to go deleting the user's messages (e.g. 8h)",
 						type: ApplicationCommandOptionType.String,
 						required: false,
 					}),
diff --git a/services/interactions/src/handlers/purge.ts b/services/interactions/src/handlers/purge.ts
index 0be32220..716b0fe9 100644
--- a/services/interactions/src/handlers/purge.ts
+++ b/services/interactions/src/handlers/purge.ts
@@ -177,7 +177,7 @@ export default class PurgeHandler implements HandlerModule<CoralInteractionHandl
 							return true;
 						}
 
-						return Boolean(message.attachments.some((a) => a.url.endsWith(`.${ext}`)));
+						return message.attachments.some((attachment) => new URL(attachment.url).pathname.endsWith(`.${ext}`));
 					};
 
 					const gifExt = ['gif', 'apng'];
@@ -187,7 +187,7 @@ export default class PurgeHandler implements HandlerModule<CoralInteractionHandl
 					switch (media) {
 						case 'all': {
 							const allExt = [...gifExt, ...imageExt, ...videoExt];
-							if (!allExt.some(checkForExtension) || message.embeds.length > 0) {
+							if (!allExt.some(checkForExtension) && !message.embeds.length) {
 								return false;
 							}