Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bound issue protection #5044

Open
wants to merge 56 commits into
base: bugfix/xbounds-iterator
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
56 commits
Select commit Hold shift + click to select a range
22e8eca
Revert https://github.com/danielgindi/Charts/pull/4271 and disable pa…
tsorencraig Jul 9, 2020
40a588f
The use of special character in folder name don't allow unzip correct…
Jun 12, 2021
b998b5a
Add tutorial links
phuanggh Jun 25, 2021
c729d8c
Merge pull request #1 from phuanggh/phuanggh-patch-1
phuanggh Jun 25, 2021
41ae51d
Fixed the use of partitioningIndex(where:) in ChartDataSet.entriesFor…
mbharry Sep 23, 2021
85cfba9
Merge pull request #4700 from GetBlast/revert_PR_4271_and_prevent_par…
liuxuan30 Dec 31, 2021
4180877
Update project settings to support publishing pod
pmairoldi Mar 11, 2022
1629bcd
Merge pull request #4791 from danielgindi/fix/update-cocoapods
pmairoldi Mar 12, 2022
b61fc9b
bump pod version
pmairoldi Mar 12, 2022
799ec91
Merge branch 'master' into 4719-highlighter-fix
kcome Mar 20, 2022
9b8433f
Properties on axis renderers to Objc (Fixes #4800)
SLambrakis Mar 25, 2022
85cc87d
Fix rounding method to "closest" if there is a result.
kcome Apr 1, 2022
e2d2038
Add back `setNeedsDisplay` when deselect currently highlighted bar.
kcome Apr 3, 2022
30538b3
Update closestXValue when rounding method is closest.
kcome Apr 12, 2022
08aff41
Remove Cocoadocs reference from README
rph8 Apr 18, 2022
23bf320
Update ChartData.swift
May 13, 2022
b44cc74
Add testMaxEntryCountSet
May 13, 2022
9f334a4
Merge pull request #4812 from rph8/master
pmairoldi May 25, 2022
eab0e40
Merge pull request #4721 from kcome/4719-highlighter-fix
pmairoldi May 25, 2022
25d2f06
Merge pull request #4669 from phuanggh/master
pmairoldi May 25, 2022
d2ae284
Merge pull request #4822 from truongtho1603/fix/crash-maxEntryCountSet
pmairoldi May 25, 2022
313c285
Merge pull request #4801 from SLambrakis/bugfix/4800-objc-axis-render…
pmairoldi May 25, 2022
b38b8d4
Bump podsepc version
pmairoldi May 25, 2022
e4a0c6d
missing Package.resolved change
FelixHerrmann May 26, 2022
d768a74
return last index for every rounding
FelixHerrmann May 26, 2022
2095115
used index APIs instead of raw integers
FelixHerrmann May 26, 2022
a9193a7
Add double mark for compiler check related with issue #4835
eliakorkmaz Jun 8, 2022
9e4c77c
Update ChartDataSet.swift
batikansosun Jul 7, 2022
65c93d4
Fix navigation bar transparent issue
wlixcc Jul 27, 2022
3af939e
Fixes protocol implementation when compiled with Swift 5.7
lukeredpath May 13, 2022
be742eb
Fix warnings
lukeredpath May 13, 2022
d925593
Update README.md
jeremyteh Aug 22, 2022
9e40f17
Fix yOffset documentation typo
erkanyildiz Aug 22, 2022
5f6edd8
Merge pull request #4886 from jeremyteh/patch-1
pmairoldi Aug 27, 2022
79cfb9a
Merge pull request #4875 from wlixcc/master
pmairoldi Aug 27, 2022
130b505
Merge pull request #4861 from batikansosun/batikansosun-patch-1
pmairoldi Aug 28, 2022
4720a29
Merge branch 'master' into lukeredpath/swift-5.7
pmairoldi Aug 28, 2022
1ae0003
Merge pull request #4823 from lukeredpath/lukeredpath/swift-5.7
pmairoldi Aug 28, 2022
c8aa118
Merge pull request #4836 from eliakorkmaz/issue-4835
pmairoldi Aug 28, 2022
4ed3db5
fix 'makeIterator()' on 'Collection' requires the types to be equivalent
pmairoldi Aug 28, 2022
2c77b2b
Merge pull request #4829 from FelixHerrmann/master
pmairoldi Aug 29, 2022
c00027a
Release 4.1
pmairoldi Sep 12, 2022
26a123e
update ci
pmairoldi Sep 12, 2022
996c588
update ci
pmairoldi Sep 12, 2022
61b9348
update readme
pmairoldi Sep 12, 2022
a20c8fe
update ci
pmairoldi Sep 12, 2022
7e9548a
update ci
pmairoldi Sep 13, 2022
f5d7473
udpate ci
pmairoldi Sep 13, 2022
2ed1022
fix tvos tests
pmairoldi Sep 13, 2022
0f4bad3
fix ios tests
pmairoldi Sep 13, 2022
07b2347
fix ios tests
pmairoldi Sep 13, 2022
19eaf62
Merge pull request #4898 from erkanyildiz/yoffset_documentation_typo
pmairoldi Sep 13, 2022
2037006
Merge pull request #4661 from rquesada/fix/4660-remove-special-character
pmairoldi Sep 13, 2022
7a22c75
Unnecessary space Removal and Semicolons are removed
Feb 28, 2023
d8d96d8
Merge pull request #5016 from guptamohit1907/master
liuxuan30 Mar 2, 2023
1bb9683
fixed index error
SequentYoie Apr 7, 2023
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 14 additions & 14 deletions .github/workflows/swift.yml
Original file line number Diff line number Diff line change
Expand Up @@ -6,59 +6,59 @@ on:
- master
pull_request:
branches:
- '*'
- "*"

jobs:
iOS:
runs-on: macos-latest
runs-on: macos-12
env:
DEVELOPER_DIR: /Applications/Xcode_12.4.app/Contents/Developer
DEVELOPER_DIR: /Applications/Xcode_14.0.app/Contents/Developer
strategy:
matrix:
destination: ["OS=14.4,name=iPhone 12 Pro"] #, "OS=12.4,name=iPhone XS", "OS=11.4,name=iPhone X", "OS=10.3.1,name=iPhone SE"]
destination: ["OS=16.0,name=iPhone 14 Pro"] #, "OS=14.4,name=iPhone 12 Pro", "OS=12.4,name=iPhone XS", "OS=11.4,name=iPhone X", "OS=10.3.1,name=iPhone SE"]
steps:
- uses: actions/checkout@v2
- name: iOS - ${{ matrix.destination }}
run: set -o pipefail && env NSUnbufferedIO=YES xcodebuild -workspace "Charts.xcworkspace" -scheme "Charts" -destination "${{ matrix.destination }}" clean test | xcpretty

tvOS:
runs-on: macos-latest
runs-on: macos-12
env:
DEVELOPER_DIR: /Applications/Xcode_12.4.app/Contents/Developer
DEVELOPER_DIR: /Applications/Xcode_14.0.app/Contents/Developer
strategy:
matrix:
destination: ["OS=14.3,name=Apple TV 4K"]
destination: ["OS=16.0,name=Apple TV 4K (2nd generation)"]
steps:
- uses: actions/checkout@v2
- name: tvOS - ${{ matrix.destination }}
run: set -o pipefail && env NSUnbufferedIO=YES xcodebuild -workspace "Charts.xcworkspace" -scheme "Charts" -destination "${{ matrix.destination }}" clean test | xcpretty

macOS_demo:
runs-on: macOS-latest
runs-on: macos-12
env:
DEVELOPER_DIR: /Applications/Xcode_12.4.app/Contents/Developer
DEVELOPER_DIR: /Applications/Xcode_14.0.app/Contents/Developer
steps:
- uses: actions/checkout@v2
- name: macOS
run: set -o pipefail && env NSUnbufferedIO=YES xcodebuild -workspace "Charts.xcworkspace" -scheme "ChartsDemo-macOS" -destination "platform=macOS" clean build | xcpretty

iOS_demo:
runs-on: macos-latest
runs-on: macos-12
env:
DEVELOPER_DIR: /Applications/Xcode_12.4.app/Contents/Developer
DEVELOPER_DIR: /Applications/Xcode_14.0.app/Contents/Developer
strategy:
matrix:
destination: ["OS=14.4,name=iPhone 12 Pro"] #, "OS=12.4,name=iPhone XS", "OS=11.4,name=iPhone X", "OS=10.3.1,name=iPhone SE"]
destination: ["OS=16.0,name=iPhone 14 Pro"] #, "OS=14.4,name=iPhone 12 Pro", "OS=12.4,name=iPhone XS", "OS=11.4,name=iPhone X", "OS=10.3.1,name=iPhone SE"]
steps:
- uses: actions/checkout@v2
- name: iOS - ${{ matrix.destination }}
run: set -o pipefail && env NSUnbufferedIO=YES xcodebuild -workspace "Charts.xcworkspace" -scheme "ChartsDemo-iOS" -destination "${{ matrix.destination }}" clean build | xcpretty

spm:
name: Test with SPM
runs-on: macOS-latest
runs-on: macos-12
env:
DEVELOPER_DIR: /Applications/Xcode_12.4.app/Contents/Developer
DEVELOPER_DIR: /Applications/Xcode_14.0.app/Contents/Developer
steps:
- uses: actions/checkout@v2
- name: SPM Test
Expand Down
1 change: 1 addition & 0 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,7 @@ DerivedData
*.ipa
*.dSYM.zip
*.dSYM
*.dia

## Playgrounds
timeline.xctimeline
Expand Down
13 changes: 7 additions & 6 deletions Charts.podspec
Original file line number Diff line number Diff line change
@@ -1,19 +1,20 @@
Pod::Spec.new do |s|
s.name = "Charts"
s.version = "4.0.0"
s.version = "4.1.0"
s.summary = "Charts is a powerful & easy to use chart library for iOS, tvOS and OSX (and Android)"
s.homepage = "https://github.com/danielgindi/Charts"
s.license = { :type => "Apache License, Version 2.0", :file => "LICENSE" }
s.authors = "Daniel Cohen Gindi", "Philipp Jahoda"
s.ios.deployment_target = "9.0"
s.tvos.deployment_target = "9.0"
s.osx.deployment_target = "10.11"
s.ios.deployment_target = "12.0"
s.tvos.deployment_target = "12.0"
s.osx.deployment_target = "10.13"
s.source = { :git => "https://github.com/danielgindi/Charts.git", :tag => "v#{s.version}" }
s.default_subspec = "Core"
s.swift_version = '5.3'
s.swift_version = '5.7'
s.cocoapods_version = '>= 1.5.0'

s.subspec "Core" do |ss|
ss.source_files = "Source/Charts/**/*.swift"
ss.dependency 'SwiftAlgorithms', '~> 1.0'
end
end
34 changes: 20 additions & 14 deletions Charts.xcodeproj/project.pbxproj
Original file line number Diff line number Diff line change
Expand Up @@ -788,7 +788,7 @@
isa = PBXProject;
attributes = {
LastSwiftUpdateCheck = 0830;
LastUpgradeCheck = 1200;
LastUpgradeCheck = 1400;
TargetAttributes = {
A58A4ED274A941CA248EA921 = {
LastSwiftMigration = 1150;
Expand Down Expand Up @@ -1022,6 +1022,7 @@
APPLICATION_EXTENSION_API_ONLY = YES;
COMBINE_HIDPI_IMAGES = YES;
CURRENT_PROJECT_VERSION = 1;
DEAD_CODE_STRIPPING = YES;
DEBUG_INFORMATION_FORMAT = dwarf;
DEFINES_MODULE = YES;
DYLIB_COMPATIBILITY_VERSION = 1;
Expand All @@ -1032,14 +1033,14 @@
GCC_NO_COMMON_BLOCKS = YES;
INFOPLIST_FILE = "Source/Supporting Files/Info.plist";
INSTALL_PATH = "$(LOCAL_LIBRARY_DIR)/Frameworks";
IPHONEOS_DEPLOYMENT_TARGET = 9.0;
IPHONEOS_DEPLOYMENT_TARGET = 12.0;
LD_RUNPATH_SEARCH_PATHS = (
"$(inherited)",
"@executable_path/../Frameworks",
"@loader_path/Frameworks",
);
MACOSX_DEPLOYMENT_TARGET = 10.11;
MARKETING_VERSION = 4.0.0;
MACOSX_DEPLOYMENT_TARGET = 10.13;
MARKETING_VERSION = 4.1.0;
MTL_ENABLE_DEBUG_INFO = YES;
PRODUCT_BUNDLE_IDENTIFIER = com.dcg.Charts;
PRODUCT_NAME = "$(TARGET_NAME)";
Expand All @@ -1049,7 +1050,7 @@
SWIFT_ACTIVE_COMPILATION_CONDITIONS = DEBUG;
SWIFT_OPTIMIZATION_LEVEL = "-Onone";
SWIFT_VERSION = 5.0;
TVOS_DEPLOYMENT_TARGET = 9.0;
TVOS_DEPLOYMENT_TARGET = 12.0;
VERSIONING_SYSTEM = "apple-generic";
VERSION_INFO_PREFIX = "";
};
Expand All @@ -1059,11 +1060,12 @@
isa = XCBuildConfiguration;
buildSettings = {
APPLICATION_EXTENSION_API_ONLY = NO;
DEAD_CODE_STRIPPING = YES;
DEBUG_INFORMATION_FORMAT = dwarf;
ENABLE_STRICT_OBJC_MSGSEND = YES;
GCC_NO_COMMON_BLOCKS = YES;
INFOPLIST_FILE = Tests/ChartsTests/Resources/Info.plist;
IPHONEOS_DEPLOYMENT_TARGET = 11.0;
IPHONEOS_DEPLOYMENT_TARGET = 12.0;
LD_RUNPATH_SEARCH_PATHS = (
"$(inherited)",
"@executable_path/Frameworks",
Expand All @@ -1082,7 +1084,7 @@
SWIFT_ACTIVE_COMPILATION_CONDITIONS = DEBUG;
SWIFT_OPTIMIZATION_LEVEL = "-Onone";
SWIFT_VERSION = 5.0;
TVOS_DEPLOYMENT_TARGET = 10.0;
TVOS_DEPLOYMENT_TARGET = 12.0;
};
name = Debug;
};
Expand Down Expand Up @@ -1121,6 +1123,7 @@
CODE_SIGN_IDENTITY = "";
COMBINE_HIDPI_IMAGES = YES;
COPY_PHASE_STRIP = YES;
DEAD_CODE_STRIPPING = YES;
ENABLE_NS_ASSERTIONS = NO;
ENABLE_STRICT_OBJC_MSGSEND = YES;
GCC_C_LANGUAGE_STANDARD = gnu99;
Expand Down Expand Up @@ -1175,6 +1178,7 @@
CODE_SIGN_IDENTITY = "";
COMBINE_HIDPI_IMAGES = YES;
COPY_PHASE_STRIP = NO;
DEAD_CODE_STRIPPING = YES;
ENABLE_STRICT_OBJC_MSGSEND = YES;
ENABLE_TESTABILITY = YES;
GCC_C_LANGUAGE_STANDARD = gnu99;
Expand Down Expand Up @@ -1207,6 +1211,7 @@
APPLICATION_EXTENSION_API_ONLY = YES;
COMBINE_HIDPI_IMAGES = YES;
CURRENT_PROJECT_VERSION = 1;
DEAD_CODE_STRIPPING = YES;
DEBUG_INFORMATION_FORMAT = "dwarf-with-dsym";
DEFINES_MODULE = YES;
DYLIB_COMPATIBILITY_VERSION = 1;
Expand All @@ -1217,14 +1222,14 @@
GCC_NO_COMMON_BLOCKS = YES;
INFOPLIST_FILE = "Source/Supporting Files/Info.plist";
INSTALL_PATH = "$(LOCAL_LIBRARY_DIR)/Frameworks";
IPHONEOS_DEPLOYMENT_TARGET = 9.0;
IPHONEOS_DEPLOYMENT_TARGET = 12.0;
LD_RUNPATH_SEARCH_PATHS = (
"$(inherited)",
"@executable_path/../Frameworks",
"@loader_path/Frameworks",
);
MACOSX_DEPLOYMENT_TARGET = 10.11;
MARKETING_VERSION = 4.0.0;
MACOSX_DEPLOYMENT_TARGET = 10.13;
MARKETING_VERSION = 4.1.0;
MTL_ENABLE_DEBUG_INFO = NO;
PRODUCT_BUNDLE_IDENTIFIER = com.dcg.Charts;
PRODUCT_NAME = "$(TARGET_NAME)";
Expand All @@ -1234,7 +1239,7 @@
SWIFT_COMPILATION_MODE = wholemodule;
SWIFT_OPTIMIZATION_LEVEL = "-O";
SWIFT_VERSION = 5.0;
TVOS_DEPLOYMENT_TARGET = 9.0;
TVOS_DEPLOYMENT_TARGET = 12.0;
VERSIONING_SYSTEM = "apple-generic";
VERSION_INFO_PREFIX = "";
};
Expand All @@ -1244,11 +1249,12 @@
isa = XCBuildConfiguration;
buildSettings = {
APPLICATION_EXTENSION_API_ONLY = NO;
DEAD_CODE_STRIPPING = YES;
DEBUG_INFORMATION_FORMAT = "dwarf-with-dsym";
ENABLE_STRICT_OBJC_MSGSEND = YES;
GCC_NO_COMMON_BLOCKS = YES;
INFOPLIST_FILE = Tests/ChartsTests/Resources/Info.plist;
IPHONEOS_DEPLOYMENT_TARGET = 11.0;
IPHONEOS_DEPLOYMENT_TARGET = 12.0;
LD_RUNPATH_SEARCH_PATHS = (
"$(inherited)",
"@executable_path/Frameworks",
Expand All @@ -1267,7 +1273,7 @@
SWIFT_COMPILATION_MODE = wholemodule;
SWIFT_OPTIMIZATION_LEVEL = "-O";
SWIFT_VERSION = 5.0;
TVOS_DEPLOYMENT_TARGET = 10.0;
TVOS_DEPLOYMENT_TARGET = 12.0;
};
name = Release;
};
Expand Down Expand Up @@ -1309,7 +1315,7 @@
repositoryURL = "https://github.com/apple/swift-algorithms";
requirement = {
kind = upToNextMajorVersion;
minimumVersion = 0.0.2;
minimumVersion = 1.0.0;
};
};
22BBDA0625CC4C2F00435670 /* XCRemoteSwiftPackageReference "swift-snapshot-testing" */ = {
Expand Down
2 changes: 1 addition & 1 deletion Charts.xcodeproj/xcshareddata/xcschemes/Charts.xcscheme
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
<?xml version="1.0" encoding="UTF-8"?>
<Scheme
LastUpgradeVersion = "1200"
LastUpgradeVersion = "1400"
version = "1.3">
<BuildAction
parallelizeBuildables = "YES"
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
<?xml version="1.0" encoding="UTF-8"?>
<Scheme
LastUpgradeVersion = "1200"
LastUpgradeVersion = "1400"
version = "1.3">
<BuildAction
parallelizeBuildables = "YES"
Expand Down
60 changes: 29 additions & 31 deletions Charts.xcworkspace/xcshareddata/swiftpm/Package.resolved
Original file line number Diff line number Diff line change
@@ -1,34 +1,32 @@
{
"object": {
"pins": [
{
"package": "swift-algorithms",
"repositoryURL": "https://github.com/apple/swift-algorithms",
"state": {
"branch": null,
"revision": "bb3bafeca0e164ece3403a9de646b7d38c07dd49",
"version": "0.0.2"
}
},
{
"package": "swift-numerics",
"repositoryURL": "https://github.com/apple/swift-numerics",
"state": {
"branch": null,
"revision": "6b24333510e9044cf4716a07bed65eeed6bc6393",
"version": "0.0.8"
}
},
{
"package": "SnapshotTesting",
"repositoryURL": "https://github.com/pointfreeco/swift-snapshot-testing",
"state": {
"branch": null,
"revision": "c466812aa2e22898f27557e2e780d3aad7a27203",
"version": "1.8.2"
}
"pins" : [
{
"identity" : "swift-algorithms",
"kind" : "remoteSourceControl",
"location" : "https://github.com/apple/swift-algorithms",
"state" : {
"revision" : "b14b7f4c528c942f121c8b860b9410b2bf57825e",
"version" : "1.0.0"
}
]
},
"version": 1
},
{
"identity" : "swift-numerics",
"kind" : "remoteSourceControl",
"location" : "https://github.com/apple/swift-numerics",
"state" : {
"revision" : "0a5bc04095a675662cf24757cc0640aa2204253b",
"version" : "1.0.2"
}
},
{
"identity" : "swift-snapshot-testing",
"kind" : "remoteSourceControl",
"location" : "https://github.com/pointfreeco/swift-snapshot-testing",
"state" : {
"revision" : "f8a9c997c3c1dab4e216a8ec9014e23144cbab37",
"version" : "1.9.0"
}
}
],
"version" : 2
}
Loading