You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
@TheNightmareX The one thing I wish I could of done but couldn't see a path to implement was get the @SoftDeletable decorator to throw an error if the subscriber wasn't registered. If you're able to see a path forward/point me in the right direction, I could open a follow up PR.
Hey @Tucker-Eric I see what you're trying to accomplish. However, it doesn't sound like a quite good practice to me.
Decorators are not supposed to do anything except of defining metadata to the target. The metadata they defined would be handled by other services.
In our case, applying a @SoftDeletable decorator to an entity class only means that the soft-delete behavior of that kind of entities has been defined, but doesn't mean that we have enabled soft-delete for it. Registering the subscriber is the way to enable the defined soft-delete behaviors.
For now I don't plan to add this feature. You could keep this issue open to see if others have some innovative opinions on this :)
Originally posted by @Tucker-Eric in #6 (comment)
The text was updated successfully, but these errors were encountered: