tweak(crates): adds overlay and height

PR #11162

code/game/machinery/computer/guestpass.dm

@@ -50,6 +50,7 @@
 	light_inner_range_on = 0.5
 	light_outer_range_on = 2
 	density = 0
+	turf_height_offset = 0
 
 	var/obj/item/card/id/giver
 	var/list/accesses = list()

code/game/machinery/cryopod.dm

@@ -27,6 +27,7 @@
 	circuit = /obj/item/circuitboard/cryopodcontrol
 	density = 0
 	interact_offline = 1
+	turf_height_offset = 0
 	var/datum/browser/browser = null
 	var/menu = MAIN
 

code/game/objects/structures/crates_lockers/closets.dm

@@ -23,7 +23,6 @@
 	var/icon_off
 
 	var/welded = FALSE
-	var/large = TRUE
 	var/wall_mounted = FALSE //never solid (You can always pass over it)
 	var/health = 100
 	var/breakout = 0 //if someone is currently breaking out. mutex
@@ -536,20 +535,20 @@
 	qdel(src)
 
 /obj/structure/closet/MouseDrop_T(atom/movable/O, mob/user)
+	if(QDELETED(O))
+		return
 	if(istype(O, /obj/screen))	//fix for HUD elements making their way into the world	-Pete
 		return
 	if(O.loc == user)
 		return
-	if(ismob(O) && src.large)
-		return
 	if(user.restrained() || user.stat || user.weakened || user.stunned || user.paralysis)
 		return
 	if((!( istype(O, /atom/movable) ) || O.anchored || !Adjacent(user) || !Adjacent(O) || !user.Adjacent(O) || user.contents.Find(src)))
 		return
 	if(!isturf(user.loc)) // are you in a container/closet/pod/etc?
 		return
-	if(!src.opened)
-		return
+	if(!opened)
+		return ..()
 	if(istype(O, /obj/structure/closet))
 		return
 	step_towards(O, src.loc)

code/game/objects/structures/crates_lockers/closets/crittercrate.dm

@@ -4,3 +4,7 @@
 	icon_state = "critter"
 	icon_opened = "critteropen"
 	icon_closed = "critter"
+
+	has_overlay = FALSE
+	turf_height_offset = 0
+	opened_turf_height_offset = 0

code/game/objects/structures/crates_lockers/closets/secure/security.dm

@@ -284,9 +284,6 @@
 	icon_off = "wall-lockeroff"
 	dremovable = 0
 
-	//too small to put a man in
-	large = 0
-
 /obj/structure/closet/secure_closet/iaa
 	name = "internal affairs secure closet"
 	req_access = list(access_iaa)

code/game/objects/structures/crates_lockers/crates.dm

@@ -18,18 +18,45 @@
 	var/points_per_crate = 5
 	var/rigged = 0
 
+	var/has_overlay = TRUE
+	var/image/crate_overlay
+
+	turf_height_offset = 14
+	var/opened_turf_height_offset = 3
+	var/closed_turf_height_offset = 0
+
+/obj/structure/closet/crate/Initialize()
+	. = ..()
+	if(!closed_turf_height_offset)
+		closed_turf_height_offset = turf_height_offset
+	if(has_overlay)
+		crate_overlay = OVERLAY(icon, "[icon_closed]over", layer = ABOVE_HUMAN_LAYER)
+	update_icon()
+
+/obj/structure/closet/crate/on_update_icon()
+	..()
+	if(opened && crate_overlay)
+		AddOverlays(crate_overlay)
+
 /obj/structure/closet/crate/open()
 	if((atom_flags & ATOM_FLAG_OPEN_CONTAINER) && !opened && can_open())
 		object_shaken()
 	. = ..()
 	if(.)
+		if(opened_turf_height_offset)
+			set_turf_height_offset(opened_turf_height_offset)
 		if(rigged)
 			visible_message(SPAN_DANGER("There are wires attached to the lid of [src]..."))
 			for(var/obj/item/device/assembly_holder/H in src)
 				H.process_activation(usr)
 			for(var/obj/item/device/assembly/A in src)
 				A.activate()
 
+/obj/structure/closet/crate/close()
+	. = ..()
+	if(. && closed_turf_height_offset)
+		set_turf_height_offset(closed_turf_height_offset)
+
 /obj/structure/closet/crate/_examine_text(mob/user)
 	. = ..()
 	if(rigged && opened)
@@ -88,10 +115,6 @@
 	setup = CLOSET_HAS_LOCK
 	locked = TRUE
 
-/obj/structure/closet/crate/secure/Initialize()
-	. = ..()
-	update_icon()
-
 /obj/structure/closet/crate/secure/on_update_icon()
 	..()
 	if(broken)
@@ -139,6 +162,9 @@
 	icon_closed = "trashcart"
 	pull_slowdown = PULL_SLOWDOWN_LIGHT
 
+	turf_height_offset = 15
+	opened_turf_height_offset = 4
+
 /obj/structure/closet/crate/medical
 	name = "medical crate"
 	desc = "A medical crate."
@@ -182,6 +208,7 @@
 	icon_state = "freezer"
 	icon_opened = "freezeropen"
 	icon_closed = "freezer"
+	turf_height_offset = 15
 	var/target_temp = -40 CELSIUS
 	var/cooling_power = 40
 
@@ -213,6 +240,9 @@
 	icon_opened = "largebinopen"
 	icon_closed = "largebin"
 
+	turf_height_offset = 16
+	opened_turf_height_offset = 2
+
 /obj/structure/closet/crate/radiation
 	name = "radioactive crate"
 	desc = "A leadlined crate with a radiation sign on it."
@@ -309,15 +339,23 @@
 	sparks = "largebinsparks"
 	emag = "largebinemag"
 
+	turf_height_offset = 16
+	opened_turf_height_offset = 2
+
 /obj/structure/closet/crate/large
 	name = "large crate"
 	desc = "A hefty metal crate."
 	icon_state = "largemetal"
 	icon_opened = "largemetalopen"
 	icon_closed = "largemetal"
+
 	storage_capacity = 2 * MOB_LARGE
 	storage_types = CLOSET_STORAGE_ITEMS|CLOSET_STORAGE_STRUCTURES
 
+	has_overlay = FALSE
+	turf_height_offset = 0
+	opened_turf_height_offset = 0
+
 /obj/structure/closet/crate/large/hydroponics
 	icon_state = "hydro_crate_large"
 	icon_opened = "hydro_crate_large_open"
@@ -335,6 +373,10 @@
 	storage_capacity = 2 * MOB_LARGE
 	storage_types = CLOSET_STORAGE_ITEMS|CLOSET_STORAGE_STRUCTURES
 
+	has_overlay = FALSE
+	turf_height_offset = 0
+	opened_turf_height_offset = 0
+
 /obj/structure/closet/crate/secure/large/plasma
 	icon_state = "plasma_crate_large"
 	icon_opened = "plasma_crate_large_open"
@@ -383,6 +425,9 @@
 	storage_types = CLOSET_STORAGE_ITEMS|CLOSET_STORAGE_MOBS
 	pull_slowdown = PULL_SLOWDOWN_LIGHT
 
+	turf_height_offset = 15
+	opened_turf_height_offset = 4
+
 /obj/structure/closet/crate/secure/biohazard/blanks/WillContain()
 	return list(/mob/living/carbon/human/blank, /obj/item/usedcryobag)
 

code/game/objects/structures/crates_lockers/largecrate.dm

@@ -6,6 +6,7 @@
 	density = 1
 	atom_flags = ATOM_FLAG_CLIMBABLE
 	pull_slowdown = PULL_SLOWDOWN_HEAVY
+	turf_height_offset = 22
 
 /obj/structure/largecrate/Initialize()
 	. = ..()

code/modules/mining/mine_items.dm

@@ -311,6 +311,9 @@
 	icon_closed = "miningcar"
 	pull_slowdown = PULL_SLOWDOWN_LIGHT
 
+	turf_height_offset = 15
+	opened_turf_height_offset = 3
+
 /**********************Pinpointer**********************/
 
 /obj/item/ore_radar

code/modules/multiz/industrial_lift/industrial_lift_console.dm

@@ -11,6 +11,7 @@
 	light_outer_range_on = 1.5
 
 	density = 0
+	turf_height_offset = 0
 	var/datum/lift_master/elevator_master
 	var/ui_template = "elevator_control_console.tmpl"