-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Was Node Suite Image Save is not transpiled #19
Comments
Every output node will be transpiled with its own script. The problem is, the hook is only triggered when the metadata is written to a png file. Other formats, like webp, will not triggerd it. It works this way because the transpiler doens't know which node may save images. I'm not sure what you are using the transpiler for. Using it in the web UI is designed to be used to generate a human-reable format of the workflow. If you want to convert workflows to scripts to use in code, then the CLI is probably better. I've also made a simply GUI for it, but not uploaded. If you want a GUI instead of a CLI, tell me, I'll polish it and upload. |
As for the "workflow", it's an internal format used by the web UI (Differences from ComfyUI's web UI). The server only needs "prompt". So the runtime doesn't use or generate workflows in the web UI's internal format. However, you can drag and drop the image generated by the runtime to the web UI, and it'll convert it to the internal format. Can you let me know why would you need it? By the way, you can turn off saving the script source by |
Thank you for your help, I was unclear, the workflow is not loaded when I drag and drop the webp file, but It is loaded with a png file, with or without Using a webp file over a png is not terrible important for me and I realize this might be a bit of an edge case, so you can close this issue if you want. |
I dug a bit and found that this is a bug of the node itself: https://github.com/WASasquatch/was-node-suite-comfyui/blob/33534f2e48682ddcf580436ea39cffc7027cbb89/WAS_Node_Suite.py#L7227-L7238. It saves the prompt in |
comfyanonymous/ComfyUI#2707. Hope it will be merged soon. Or you can modify |
It was merged and I updated ComfyUI, checked app.js for the change. Still does not work. Can't upload webp to github, so here is link https://drive.google.com/file/d/1IxlsA5OMxaHD0f3sYbrwExV-hxhMDqWl/view?usp=sharing The embedding looks a bit weird, it starts with A webp generated from the web UI looks like: |
Oh, I didn't notice that there is another bug in WAS Image Save: it will save |
workflow (79).json
Not transpiled, also when I added the "was node suite image save" to my script manually and ran the script it embedded the whole script to the image and not the workflow.
The text was updated successfully, but these errors were encountered: