-
Notifications
You must be signed in to change notification settings - Fork 154
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Error while deserializing EthFilterSpec
#4826
Labels
Type: Bug
Something isn't working
Comments
@elmattic forest/src/rpc/methods/eth/types.rs Lines 351 to 355 in a875e3d
correct curl cmd:
|
Yes, that works, but a scalar is also possible instead of a list. |
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the bug
We don't support deserializing of "topics" correctly.
To reproduce
Run Forest and this Curl command:
Log output
You should see:
Expected behavior
We should be able to deserialize this type.
We should have complete test coverage.
Screenshots
Environment (please complete the following information):
Other information and links
Note I have already fixed topics here to allow for null topics.
Spec:
https://github.com/filecoin-project/lotus/blob/master/chain/types/ethtypes/eth_types.go#L676-L688
The text was updated successfully, but these errors were encountered: