Upgrade substrate to version 9.26 #482
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Brian Hoang seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
Fix compile all test case
Fix some panic config
…e some unused code
Price feed orml oracle
Fix origin max encode len
ghost
changed the title
Add price feed test
Fix pint feature genesis
Wiezzel
reviewed
Oct 5, 2022
There was a problem hiding this comment.
There is a lot of commented-out code in this PR. In my opinion it should be either:
a) Removed, or
b) Uncommented, or
c) Accompanied by some explanation why it's commented-out and when is it supposed to change.
Apart from these, I didn't find any problems with the code. Keep in mind though that I'm not familiar with this project. If there are some parts you're not sure about and you'd like to be reviewed closer, feel free to ask.
| @@ -22,21 +22,23 @@ runtime-benchmarks = [ | |||
| 'dev-runtime/runtime-benchmarks', | |||
| 'shot-runtime/runtime-benchmarks', | |||
| 'pint-runtime/runtime-benchmarks', | |||
| 'polkadot-service/runtime-benchmarks' | |||
| # 'polkadot-service/runtime-benchmarks' | |||
There was a problem hiding this comment.
Why is this line commented out? A temporary disable or was it supposed to be removed?
| use cumulus_primitives_core::ParaId; | ||
| use log::info; | ||
| use polkadot_parachain::primitives::AccountIdConversion; | ||
| use primitives::Block; | ||
| // use polkadot_parachain::primitives::AccountIdConversion; |
| let genesis_state = format!("0x{:?}", HexDisplay::from(&block.header().encode())); | ||
| // let block: Block = | ||
| // generate_genesis_block(&config.chain_spec, state_version).map_err(|e| format!("{:?}", e))?; | ||
| // let genesis_state = format!("0x{:?}", HexDisplay::from(&block.header().encode())); |
| info!("Is collating: {}", if config.role.is_authority() { "yes" } else { "no" }); | ||
| // info!("Parachain Account: {}", parachain_account); | ||
| // info!("Parachain genesis state: {}", genesis_state); | ||
| // info!("Is collating: {}", if config.role.is_authority() { "yes" } else { "no" }); |
| // raw_downward_messages: vec![], | ||
| // raw_horizontal_messages: vec![], | ||
| // } | ||
| // } |
| @@ -217,13 +223,15 @@ impl pallet_sudo::Config for Runtime { | |||
|
|
|||
| impl cumulus_pallet_parachain_system::Config for Runtime { | |||
| type Event = Event; | |||
| type OnValidationData = (); | |||
| // type OnValidationData = (); | |||
| } | ||
|
|
||
| impl orml_currencies::Config for Runtime { | ||
| type Event = Event; | ||
| // type Event = Event; |
| type OnChargeTransaction = pallet_transaction_payment::CurrencyAdapter<Balances, ()>; | ||
| type TransactionByteFee = TransactionByteFee; | ||
| // type TransactionByteFee = TransactionByteFee; |
| @@ -214,13 +220,15 @@ impl pallet_sudo::Config for Runtime { | |||
|
|
|||
| impl cumulus_pallet_parachain_system::Config for Runtime { | |||
| type Event = Event; | |||
| type OnValidationData = (); | |||
| // type OnValidationData = (); | |||
| } | ||
|
|
||
| impl orml_currencies::Config for Runtime { | ||
| type Event = Event; | ||
| // type Event = Event; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Tests
Issues