From c9d5f9bccaab5866b3953d5430f5c3b4ae663b6c Mon Sep 17 00:00:00 2001 From: miguelmtzinf Date: Fri, 13 Sep 2024 14:44:15 +0200 Subject: [PATCH] fix: Fix solc warnings --- src/contracts/misc/GhoAaveSteward.sol | 2 +- src/test/TestGhoAaveSteward.t.sol | 3 --- src/test/mocks/MockUpgradeableBurnMintTokenPool.sol | 3 +-- src/test/mocks/MockUpgradeableLockReleaseTokenPool.sol | 3 +-- 4 files changed, 3 insertions(+), 8 deletions(-) diff --git a/src/contracts/misc/GhoAaveSteward.sol b/src/contracts/misc/GhoAaveSteward.sol index 1e66ad1b..5481f064 100644 --- a/src/contracts/misc/GhoAaveSteward.sol +++ b/src/contracts/misc/GhoAaveSteward.sol @@ -7,7 +7,7 @@ import {IPoolAddressesProvider} from '@aave/core-v3/contracts/interfaces/IPoolAd import {IPool} from '@aave/core-v3/contracts/interfaces/IPool.sol'; import {DataTypes} from '@aave/core-v3/contracts/protocol/libraries/types/DataTypes.sol'; import {ReserveConfiguration} from '@aave/core-v3/contracts/protocol/libraries/configuration/ReserveConfiguration.sol'; -import {IPoolConfigurator, IDefaultInterestRateStrategyV2, DefaultReserveInterestRateStrategyV2} from './dependencies/AaveV3-1.sol'; +import {IPoolConfigurator, IDefaultInterestRateStrategyV2} from './dependencies/AaveV3-1.sol'; import {IGhoAaveSteward} from './interfaces/IGhoAaveSteward.sol'; import {RiskCouncilControlled} from './RiskCouncilControlled.sol'; diff --git a/src/test/TestGhoAaveSteward.t.sol b/src/test/TestGhoAaveSteward.t.sol index 105053e6..8b546b25 100644 --- a/src/test/TestGhoAaveSteward.t.sol +++ b/src/test/TestGhoAaveSteward.t.sol @@ -661,9 +661,6 @@ contract TestGhoAaveSteward is TestGhoBase { } function testRevertUpdateGhoBorrowRateIfValueMoreThanMax() public { - address currentInterestRateStrategy = POOL.getReserveInterestRateStrategyAddress( - address(GHO_TOKEN) - ); uint32 maxGhoBorrowRate = GHO_BORROW_RATE_MAX; _setGhoBorrowRateViaConfigurator(maxGhoBorrowRate); vm.prank(RISK_COUNCIL); diff --git a/src/test/mocks/MockUpgradeableBurnMintTokenPool.sol b/src/test/mocks/MockUpgradeableBurnMintTokenPool.sol index 45b78af8..4865ac90 100644 --- a/src/test/mocks/MockUpgradeableBurnMintTokenPool.sol +++ b/src/test/mocks/MockUpgradeableBurnMintTokenPool.sol @@ -57,6 +57,7 @@ contract MockUpgradeableBurnMintTokenPool is Initializable { address router, uint256 bridgeLimit ) public virtual initializer { + allowlist; if (owner == address(0)) revert ZeroAddressNotAllowed(); if (router == address(0)) revert ZeroAddressNotAllowed(); _transferOwnership(owner); @@ -77,12 +78,10 @@ contract MockUpgradeableBurnMintTokenPool is Initializable { function setBridgeLimit(uint256 newBridgeLimit) external { if (msg.sender != s_bridgeLimitAdmin && msg.sender != owner()) revert Unauthorized(msg.sender); - uint256 oldBridgeLimit = s_bridgeLimit; s_bridgeLimit = newBridgeLimit; } function setBridgeLimitAdmin(address bridgeLimitAdmin) external { - address oldAdmin = s_bridgeLimitAdmin; s_bridgeLimitAdmin = bridgeLimitAdmin; } diff --git a/src/test/mocks/MockUpgradeableLockReleaseTokenPool.sol b/src/test/mocks/MockUpgradeableLockReleaseTokenPool.sol index fa8def8b..774671ee 100644 --- a/src/test/mocks/MockUpgradeableLockReleaseTokenPool.sol +++ b/src/test/mocks/MockUpgradeableLockReleaseTokenPool.sol @@ -57,6 +57,7 @@ contract MockUpgradeableLockReleaseTokenPool is Initializable { address router, uint256 bridgeLimit ) public virtual initializer { + allowlist; if (owner == address(0)) revert ZeroAddressNotAllowed(); if (router == address(0)) revert ZeroAddressNotAllowed(); _transferOwnership(owner); @@ -77,12 +78,10 @@ contract MockUpgradeableLockReleaseTokenPool is Initializable { function setBridgeLimit(uint256 newBridgeLimit) external { if (msg.sender != s_bridgeLimitAdmin && msg.sender != owner()) revert Unauthorized(msg.sender); - uint256 oldBridgeLimit = s_bridgeLimit; s_bridgeLimit = newBridgeLimit; } function setBridgeLimitAdmin(address bridgeLimitAdmin) external { - address oldAdmin = s_bridgeLimitAdmin; s_bridgeLimitAdmin = bridgeLimitAdmin; }