Skip to content

Latest commit

 

History

History
89 lines (52 loc) · 3 KB

335-treasury-management-polygon-v2-v3-migration.md

File metadata and controls

89 lines (52 loc) · 3 KB

Proposal 335 (303 re-submitted). Treasury Management - Polygon aToken v2 -> v3 migration


Voting link

https://app.aave.com/governance/proposal/?proposalId=335


Governance forum discussion

https://governance.aave.com/t/arfc-migrate-consolidate-polygon-treasury/12248


BGD analysis


Proposal types

🏦 treasury


Context

This proposal consolidates treasury assets into the Aave v3 Collector, by migrating from aTokens from Aave v2 Polygon to v3.


Proposal creation

Transaction: https://etherscan.io/tx/0x8445824f79d95c75fa23d74a03bd3124f7b80990207a24707504d146638d965a

- id: 335
- creator: 0x329c54289ff5d6b7b7dae13592c6b1eda1543ed4
- executor: 0xee56e2b3d491590b5b31738cc34d5232f378a8d5
- targets: [0x158a6bc04f0828318821bae797f50b0a1299d45b]
- values: [0]
- signatures: [execute(address)]
- calldatas: [0x000000000000000000000000c34a9391c08b64c4a9167d9e1e884b3735ce21b0]
- withDelegatecalls: [true]
- startBlock: 18271373
- endBlock: 18290573
- strategy: 0xb7e383ef9b1e9189fc0f71fb30af8aa14377429e
- ipfsHash: 0x29b067e7a40655570b2ef0b52a4f3fe3259460ea62a33ac07cff9e30a0fb58f9

Aave Seatbelt report

Ethereum

https://github.com/bgd-labs/seatbelt-for-ghosts/blob/main/reports/Aave/0xEC568fffba86c094cf06b22134B23074DFE2252c/335.md

Polygon

https://github.com/bgd-labs/seatbelt-for-ghosts/blob/main/reports/Aave/0xEC568fffba86c094cf06b22134B23074DFE2252c/335_Polygon_59.md


Technical analysis

We have verified the proposal payload properly migrates a list of 10 Aave v2 Polygon aTokens (aDAI, aUSDC, aUSDT, aWBTC, aWETH, aWMATIC, aBAL, aCRV, aGHST and aLINK) to their v3 version, by doing the following:

  1. First, the payload withdraws the aTokens from the Aave Polygon Collector.
  2. The payload approves the BGD v2->v3 Migration Helper contract to use the v2 aTokens.
  3. The migration v2->v3 is done, by calling migrate() on the Migrator Helper.
  4. The resultant Aave v3 Polygon aTokens are deposited into the Aave Polygon Collector.

BGD validations

✅ The code on the proposal payload corresponds to the proposal specification.

✅ The proposal includes a proper tests suite, checking all necessary post-conditions.

✅ BGD reviewed the payload before the proposal was submitted.

✅ Only one payload used via delegatecall

✅ BGD reviewed the procedure followed to submit the proposal.