Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Separation of concerns in ServiceInvoker #6

Open
rpierry opened this issue Jun 22, 2015 · 3 comments
Open

Separation of concerns in ServiceInvoker #6

rpierry opened this issue Jun 22, 2015 · 3 comments

Comments

@rpierry
Copy link
Contributor

rpierry commented Jun 22, 2015

Refactor the implementation of ServiceInvoker to better separate concerns.
rpierry added a commit that referenced this issue Jun 23, 2015
@rpierry
#6 - refactor serviceinvoker, split message parsing into a new class
ffc5d59
@rpierry
Copy link
Contributor Author

rpierry commented Jun 23, 2015

@Tolk-Haggard @dfschwabe @jruckle - are there other examples left to address? My last few commits have ended up refactoring serviceinvoker, client, and a few other places to make them better. I may have already addressed your concerns.

@dfschwabe
Copy link

I think we are at the point of diminishing returns for this issue.

rpierry added a commit that referenced this issue Jul 7, 2015
@rpierry
#6 - refactor serviceinvoker, split message parsing into a new class
259d5ae
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@rpierry @dfschwabe and others