Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pmvpdd differences in Py and R. #117

Open
2 tasks
number9527-12 opened this issue Sep 6, 2024 · 3 comments
Open
2 tasks

pmvpdd differences in Py and R. #117

number9527-12 opened this issue Sep 6, 2024 · 3 comments
Assignees
Milestone

Comments

@number9527-12
Copy link

number9527-12 commented Sep 6, 2024

Describe the bug
Her are the differences we have identified

  • calculation of xf
  • calculation of tcla

xf

In py the function is link
xf = t_cla / 50
in R is link
xf <- xn

tcla

py t_cla = taa + (35.5 - tdb) / (3.5 * icl + 0.1)
r tclA <- taa + (35.5-ta) / (3.5 * (6.45 * icl + .1))

@FedericoTartarini and marcel to review

@FedericoTartarini
Copy link
Collaborator

In the ISO 7730 the equations are
image

image

but in the ASHRAE 55
image

image

Consequently the equation in R for tcla seems to be incorrect.
Marcel what do you think about the xf?

@marcelschweiker
Copy link
Collaborator

Interesting to see the differences for XF between ISO 7730 and ASHRAE 55. I have no explanation for these.
As for tcla, in the ISO 7730 version, I have (2005 version + unpublished 2023 draft) it is
image
so in this case R would be correct. In any case, I would not expect too big differences in outcome as this line of code only affects the first guess for the surface temperature of the clothing, which will then be adjusted in iterations in the following loop and should result in the same value after the loop?

@FedericoTartarini
Copy link
Collaborator

@marcelschweiker great now I can tag you in the issues.

@FedericoTartarini FedericoTartarini self-assigned this Oct 16, 2024
@FedericoTartarini FedericoTartarini added this to the v3 milestone Oct 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants