Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PL - TVP VOD] Add kids content from PL TVP VOD #1232

Conversation

thomas-ernest
Copy link
Contributor

Add kids content from PL TVP VOD
Note : Limited support :

  • Only cartoons.
  • No authentication supported.

@joaopa00
Copy link
Contributor

joaopa00 commented Oct 4, 2023

'catalog': 'https://vod.tvp.pl/api/products/vods?&firstResult={first}&maxResults={size}&' +
'mainCategoryId[]=24&sort=createdAt&order=desc&ln={ln}&platform={pla}',

PLease use the params argument of urlquick instead hardcodingsuch long url. It is cleaner and easier to read. Have a look at your previous commit. I modified your patches in this way.

If you wish, you can add yourself in copyright for new files.

@thomas-ernest thomas-ernest force-pushed the feature/add_tvp_vod_for_kids branch from 4a15174 to 4097ea2 Compare October 5, 2023 20:52
@thomas-ernest thomas-ernest changed the title DO NO MERGE YET [PL - TVP VOD] Add kids content from PL TVP VOD [PL - TVP VOD] Add kids content from PL TVP VOD Oct 5, 2023
@thomas-ernest
Copy link
Contributor Author

Hello,

I improved the parameter management in request. A very little bit error management to limit usqge of exception especiqlly.
I don't see the need to add a copyright today.
Feel free to share other comments to improve the code. No hurry into delivering it.

I don't know why the build hasn't restarted since my last commit.

Best regards

@joaopa00 joaopa00 merged commit 6fa7ec7 into Catch-up-TV-and-More:dev Oct 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants