From bffa927bd6f860d44568f3d23ef294a0426348be Mon Sep 17 00:00:00 2001 From: Miguel Angel Moreno Date: Mon, 1 Jul 2024 10:31:13 +0200 Subject: [PATCH 01/47] :hammer_and_wrench: Automatically create NPM releases --- .github/workflows/ci.yml | 74 +++++++++++++++++++++++++--------------- 1 file changed, 47 insertions(+), 27 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 32c725d..fe23749 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -3,47 +3,67 @@ name: CI on: push: branches: [main] + tags: [v*] + pull_request: - branches: [main] + # FIMXE: + # branches: [main] jobs: build: - runs-on: ubuntu-latest + runs-on: ubuntu-22.04 strategy: matrix: - node-version: [18.x, 20.x, 22.x] + # FIXME: + # node-version: [18.x, 20.x, 22.x] + node-version: [18.x] env: CI: true steps: - - uses: actions/checkout@v4 - - name: Use Node.js ${{ matrix.node-version }} - uses: actions/setup-node@v4 - with: - node-version: ${{ matrix.node-version }} - - run: corepack enable - - run: yarn install - - run: yarn build - - run: yarn test + - name: Checkout + uses: actions/checkout@v4 - lint: - runs-on: ubuntu-latest + # - name: Set up Node.js ${{ matrix.node-version }} + # uses: actions/setup-node@v4 + # with: + # # FIXME: Is this necessary? + # node-version: ${{ matrix.node-version }} + # registry-url: https://npm.pkg.github.com + # scope: '@CartoDB' - strategy: - matrix: - node-version: [22.x] + # - name: Enable Corepack + # run: corepack enable - env: - CI: true + # - name: Install + # run: yarn install - steps: - - uses: actions/checkout@v4 - - name: Use Node.js ${{ matrix.node-version }} - uses: actions/setup-node@v4 + # - name: Build + # run: yarn build + + # - name: Lint + # run: yarn lint + + # - name: Test + # run: yarn test + + - name: Get release type + id: get-release-type + uses: actions/github-script@v7 with: - node-version: ${{ matrix.node-version }} - - run: corepack enable - - run: yarn install - - run: yarn lint + script: | + const regex = '/(alpha|beta)/i' + // FIXME: + // const refName = context.ref.replace('refs/tags/', '') + const refName = 'v0.0.1-alpha.0' + const releaseType = (refName.match(regex))[0] + console.log(`Release type: ${releaseType}`) + return releaseType + + # - name: Publish release + # if: startsWith(github.ref, 'refs/tags/') + # env: + # NODE_AUTH_TOKEN: ${{ secrets.GITHUB_TOKEN }} + # run: npm publish From d75daacf1b9e72e16e46e9351ad6779b41442bb1 Mon Sep 17 00:00:00 2001 From: Miguel Angel Moreno Date: Mon, 1 Jul 2024 10:33:22 +0200 Subject: [PATCH 02/47] Fix regex --- .github/workflows/ci.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index fe23749..51707de 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -54,7 +54,7 @@ jobs: uses: actions/github-script@v7 with: script: | - const regex = '/(alpha|beta)/i' + const regex = '/(alpha|beta)/' // FIXME: // const refName = context.ref.replace('refs/tags/', '') const refName = 'v0.0.1-alpha.0' From 55f1298807e2a58b3954975fe94703177fd3b288 Mon Sep 17 00:00:00 2001 From: Miguel Angel Moreno Date: Mon, 1 Jul 2024 10:33:46 +0200 Subject: [PATCH 03/47] Fix regex --- .github/workflows/ci.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 51707de..b50d683 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -54,7 +54,7 @@ jobs: uses: actions/github-script@v7 with: script: | - const regex = '/(alpha|beta)/' + const regex = /(alpha|beta)/ // FIXME: // const refName = context.ref.replace('refs/tags/', '') const refName = 'v0.0.1-alpha.0' From fe439f9e440d54c59507b0bee5fa75d5929ff002 Mon Sep 17 00:00:00 2001 From: Miguel Angel Moreno Date: Mon, 1 Jul 2024 10:37:02 +0200 Subject: [PATCH 04/47] Add sample tag --- .github/workflows/ci.yml | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index b50d683..8017538 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -55,9 +55,7 @@ jobs: with: script: | const regex = /(alpha|beta)/ - // FIXME: - // const refName = context.ref.replace('refs/tags/', '') - const refName = 'v0.0.1-alpha.0' + const refName = context.ref.replace('refs/tags/', '') const releaseType = (refName.match(regex))[0] console.log(`Release type: ${releaseType}`) return releaseType From 23de01496edb1f8173b44045afdc4f33c4cda391 Mon Sep 17 00:00:00 2001 From: Miguel Angel Moreno Date: Mon, 1 Jul 2024 10:38:12 +0200 Subject: [PATCH 05/47] Add sample tag --- .github/workflows/ci.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 8017538..3701e56 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -56,6 +56,7 @@ jobs: script: | const regex = /(alpha|beta)/ const refName = context.ref.replace('refs/tags/', '') + console.log(`Ref name: ${refName}`) const releaseType = (refName.match(regex))[0] console.log(`Release type: ${releaseType}`) return releaseType From 995d04673a45f3312f99d83e33f27f5749126eb8 Mon Sep 17 00:00:00 2001 From: Miguel Angel Moreno Date: Mon, 1 Jul 2024 10:39:31 +0200 Subject: [PATCH 06/47] Run only on tag push --- .github/workflows/ci.yml | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 3701e56..5129a7a 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -2,10 +2,11 @@ name: CI on: push: - branches: [main] + # FIXME: + # branches: [main] tags: [v*] - pull_request: + # pull_request: # FIMXE: # branches: [main] From 022963ab92224e8e24eb583255b53fb3b8bfbbcd Mon Sep 17 00:00:00 2001 From: Miguel Angel Moreno Date: Mon, 1 Jul 2024 10:41:10 +0200 Subject: [PATCH 07/47] Run only on tag push From 0a195822084a836ea427e7f2af559093178383fb Mon Sep 17 00:00:00 2001 From: Miguel Angel Moreno Date: Mon, 1 Jul 2024 10:42:35 +0200 Subject: [PATCH 08/47] Run only on tag push --- .github/workflows/ci.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 5129a7a..1d2562c 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -4,6 +4,7 @@ on: push: # FIXME: # branches: [main] + branches: [feature/sc-420243/ci-configuration] tags: [v*] # pull_request: From 42b38c07f257c2114a3e365c552075f07cac80bf Mon Sep 17 00:00:00 2001 From: Miguel Angel Moreno Date: Mon, 1 Jul 2024 10:47:51 +0200 Subject: [PATCH 09/47] Only run on tag push --- .github/workflows/ci.yml | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 1d2562c..eaae1a8 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -4,7 +4,7 @@ on: push: # FIXME: # branches: [main] - branches: [feature/sc-420243/ci-configuration] + # branches: [feature/sc-420243/ci-configuration] tags: [v*] # pull_request: @@ -52,6 +52,7 @@ jobs: # run: yarn test - name: Get release type + if: startsWith(github.ref, 'refs/tags/') id: get-release-type uses: actions/github-script@v7 with: From 7ab1673416179054bf6f086797b0b849b4c1d893 Mon Sep 17 00:00:00 2001 From: Miguel Angel Moreno Date: Mon, 1 Jul 2024 10:54:15 +0200 Subject: [PATCH 10/47] Add tag validations --- .github/workflows/ci.yml | 20 ++++++++++++++++++++ 1 file changed, 20 insertions(+) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index eaae1a8..0e299d7 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -28,6 +28,10 @@ jobs: - name: Checkout uses: actions/checkout@v4 + ### + # Build + ### + # - name: Set up Node.js ${{ matrix.node-version }} # uses: actions/setup-node@v4 # with: @@ -51,6 +55,22 @@ jobs: # - name: Test # run: yarn test + ### + # Release + ### + + - name: Check tag format + id: check-tag-format + if: startsWith(github.ref, 'refs/tags/') + uses: nowsprinting/check-version-format-action@v4 + with: + prefix: 'v' + + - name: Check if tag format is valid + if: startsWith(github.ref, 'refs/tags/') && steps.check-tag-format.outputs.is_valid == 'false' + run: | + echo "Invalid tag format, it must follow SemVer. Aborting." && exit 1 + - name: Get release type if: startsWith(github.ref, 'refs/tags/') id: get-release-type From ad44b848c4ee01f2cea38ca949b4dbb405f5d167 Mon Sep 17 00:00:00 2001 From: Miguel Angel Moreno Date: Mon, 1 Jul 2024 11:01:12 +0200 Subject: [PATCH 11/47] Add tag latest option --- .github/workflows/ci.yml | 13 +++++++++---- 1 file changed, 9 insertions(+), 4 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 0e299d7..43eaf72 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -66,10 +66,10 @@ jobs: with: prefix: 'v' - - name: Check if tag format is valid + - name: Exit on invalid tag format if: startsWith(github.ref, 'refs/tags/') && steps.check-tag-format.outputs.is_valid == 'false' run: | - echo "Invalid tag format, it must follow SemVer. Aborting." && exit 1 + echo "Tag must follow SemVer convention. Aborting." && exit 1 - name: Get release type if: startsWith(github.ref, 'refs/tags/') @@ -80,8 +80,13 @@ jobs: const regex = /(alpha|beta)/ const refName = context.ref.replace('refs/tags/', '') console.log(`Ref name: ${refName}`) - const releaseType = (refName.match(regex))[0] - console.log(`Release type: ${releaseType}`) + const releaseTypeMatch = refName.match(regex) + if (!releaseTypeMatch) { + releaseType = 'latest' + } else { + releaseType = refName.match(regex)[0] + } + console.log(`Release type: ${releaseType}`); return releaseType # - name: Publish release From 9729780ac0a410c650de99d4621d1d790f8db9bc Mon Sep 17 00:00:00 2001 From: Miguel Angel Moreno Date: Mon, 1 Jul 2024 11:04:30 +0200 Subject: [PATCH 12/47] Add tag latest option --- .github/workflows/ci.yml | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 43eaf72..2c981b1 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -68,8 +68,7 @@ jobs: - name: Exit on invalid tag format if: startsWith(github.ref, 'refs/tags/') && steps.check-tag-format.outputs.is_valid == 'false' - run: | - echo "Tag must follow SemVer convention. Aborting." && exit 1 + run: echo "Tag must follow SemVer convention. Aborting." && exit 1 - name: Get release type if: startsWith(github.ref, 'refs/tags/') @@ -84,9 +83,9 @@ jobs: if (!releaseTypeMatch) { releaseType = 'latest' } else { - releaseType = refName.match(regex)[0] + releaseType = releaseTypeMatch[0] } - console.log(`Release type: ${releaseType}`); + console.log(`Release type: ${releaseType}`) return releaseType # - name: Publish release From 224dd4f237de5a7d6ab058498b044848cdc21205 Mon Sep 17 00:00:00 2001 From: Miguel Angel Moreno Date: Mon, 1 Jul 2024 11:11:56 +0200 Subject: [PATCH 13/47] Install Node --- .github/workflows/ci.yml | 23 +++++++++++------------ 1 file changed, 11 insertions(+), 12 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 2c981b1..8a7cf8a 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -13,6 +13,7 @@ on: jobs: build: + name: Build [Node.js ${{ matrix.node-version }}] runs-on: ubuntu-22.04 strategy: @@ -32,13 +33,11 @@ jobs: # Build ### - # - name: Set up Node.js ${{ matrix.node-version }} - # uses: actions/setup-node@v4 - # with: - # # FIXME: Is this necessary? - # node-version: ${{ matrix.node-version }} - # registry-url: https://npm.pkg.github.com - # scope: '@CartoDB' + - name: Set up Node.js ${{ matrix.node-version }} + uses: actions/setup-node@v4 + with: + node-version: ${{ matrix.node-version }} + registry-url: https://npm.pkg.github.com # - name: Enable Corepack # run: corepack enable @@ -88,8 +87,8 @@ jobs: console.log(`Release type: ${releaseType}`) return releaseType - # - name: Publish release - # if: startsWith(github.ref, 'refs/tags/') - # env: - # NODE_AUTH_TOKEN: ${{ secrets.GITHUB_TOKEN }} - # run: npm publish + - name: Publish release + if: startsWith(github.ref, 'refs/tags/') + env: + NODE_AUTH_TOKEN: ${{ secrets.GITHUB_TOKEN }} + run: npm publish --tag ${{steps.get-release-type.outputs.result}} From 3987aadc2c404eb378724d2ce6da3950c0f9a9c8 Mon Sep 17 00:00:00 2001 From: Miguel Angel Moreno Date: Mon, 1 Jul 2024 11:14:22 +0200 Subject: [PATCH 14/47] Enable corepack --- .github/workflows/ci.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 8a7cf8a..3db8d44 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -39,8 +39,8 @@ jobs: node-version: ${{ matrix.node-version }} registry-url: https://npm.pkg.github.com - # - name: Enable Corepack - # run: corepack enable + - name: Enable Corepack + run: corepack enable # - name: Install # run: yarn install From 9780c8b30acd347f382bdda295d22adeed507445 Mon Sep 17 00:00:00 2001 From: Miguel Angel Moreno Date: Mon, 1 Jul 2024 11:16:06 +0200 Subject: [PATCH 15/47] Install CI --- .github/workflows/ci.yml | 12 +++++++----- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 3db8d44..3fc8a9b 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -42,11 +42,13 @@ jobs: - name: Enable Corepack run: corepack enable - # - name: Install - # run: yarn install + - name: Install + run: yarn install - # - name: Build - # run: yarn build + - name: Build + run: yarn build + + # FIXME: # - name: Lint # run: yarn lint @@ -77,7 +79,7 @@ jobs: script: | const regex = /(alpha|beta)/ const refName = context.ref.replace('refs/tags/', '') - console.log(`Ref name: ${refName}`) + console.log(`Ref tag: ${refName}`) const releaseTypeMatch = refName.match(regex) if (!releaseTypeMatch) { releaseType = 'latest' From 94438fd679572318d2d3226ccce4ad8bd66ced36 Mon Sep 17 00:00:00 2001 From: Miguel Angel Moreno Date: Mon, 1 Jul 2024 11:25:42 +0200 Subject: [PATCH 16/47] Add scope --- .github/workflows/ci.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 3fc8a9b..7d224e0 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -38,6 +38,7 @@ jobs: with: node-version: ${{ matrix.node-version }} registry-url: https://npm.pkg.github.com + scope: '@CartoDB' - name: Enable Corepack run: corepack enable From d5b91f65aebdbd4a2f9e3a3dbd1b7e2247c8040b Mon Sep 17 00:00:00 2001 From: Miguel Angel Moreno Date: Mon, 1 Jul 2024 11:27:17 +0200 Subject: [PATCH 17/47] Add yarn npm publish --- .github/workflows/ci.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 7d224e0..78393f4 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -94,4 +94,4 @@ jobs: if: startsWith(github.ref, 'refs/tags/') env: NODE_AUTH_TOKEN: ${{ secrets.GITHUB_TOKEN }} - run: npm publish --tag ${{steps.get-release-type.outputs.result}} + run: yarn npm publish --tag ${{steps.get-release-type.outputs.result}} From 241cc3609c1d8562f0329b120db2fef673a9dfb0 Mon Sep 17 00:00:00 2001 From: Miguel Angel Moreno Date: Mon, 1 Jul 2024 11:33:36 +0200 Subject: [PATCH 18/47] Set always-auth --- .github/workflows/ci.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 78393f4..9a86e76 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -39,6 +39,7 @@ jobs: node-version: ${{ matrix.node-version }} registry-url: https://npm.pkg.github.com scope: '@CartoDB' + always-auth: true - name: Enable Corepack run: corepack enable From 13255aa1865d19191ae54e0fc9dc5fb4577d9eb7 Mon Sep 17 00:00:00 2001 From: Miguel Angel Moreno Date: Mon, 1 Jul 2024 11:57:37 +0200 Subject: [PATCH 19/47] Add yarn auth --- .github/workflows/ci.yml | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 9a86e76..202e38b 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -91,6 +91,13 @@ jobs: console.log(`Release type: ${releaseType}`) return releaseType + - name: Configure yarn auth + if: startsWith(github.ref, 'refs/tags/') + env: + NODE_AUTH_TOKEN: ${{ secrets.GITHUB_TOKEN }} + run: | + yarn config set npmAuthToken "${NODE_AUTH_TOKEN}" + - name: Publish release if: startsWith(github.ref, 'refs/tags/') env: From 3d77bbae80850c7a41f76044e8dcf5aa443d64c5 Mon Sep 17 00:00:00 2001 From: Miguel Angel Moreno Date: Mon, 1 Jul 2024 12:01:14 +0200 Subject: [PATCH 20/47] Add yanr publish repo --- .github/workflows/ci.yml | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 202e38b..c5019c0 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -39,7 +39,6 @@ jobs: node-version: ${{ matrix.node-version }} registry-url: https://npm.pkg.github.com scope: '@CartoDB' - always-auth: true - name: Enable Corepack run: corepack enable @@ -91,11 +90,14 @@ jobs: console.log(`Release type: ${releaseType}`) return releaseType - - name: Configure yarn auth + # This additional step is needed to configure the yarn auth token + # https://docs.github.com/en/actions/publishing-packages/publishing-nodejs-packages#publishing-packages-using-yarn + - name: Configure yarn to publish if: startsWith(github.ref, 'refs/tags/') env: NODE_AUTH_TOKEN: ${{ secrets.GITHUB_TOKEN }} run: | + yarn config set npmPublishRegistry "https://npm.pkg.github.com" yarn config set npmAuthToken "${NODE_AUTH_TOKEN}" - name: Publish release From d9634a12b2671d88d8b48aec244fba73aaec8bc8 Mon Sep 17 00:00:00 2001 From: Miguel Angel Moreno Date: Mon, 1 Jul 2024 12:13:34 +0200 Subject: [PATCH 21/47] Add yanr publish repo --- .github/workflows/ci.yml | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index c5019c0..b38da38 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -37,8 +37,6 @@ jobs: uses: actions/setup-node@v4 with: node-version: ${{ matrix.node-version }} - registry-url: https://npm.pkg.github.com - scope: '@CartoDB' - name: Enable Corepack run: corepack enable @@ -97,8 +95,7 @@ jobs: env: NODE_AUTH_TOKEN: ${{ secrets.GITHUB_TOKEN }} run: | - yarn config set npmPublishRegistry "https://npm.pkg.github.com" - yarn config set npmAuthToken "${NODE_AUTH_TOKEN}" + yarn config set 'npmRegistries["//npm.pkg.github.com"].npmAuthToken' "${NODE_AUTH_TOKEN}" - name: Publish release if: startsWith(github.ref, 'refs/tags/') From 7bb5e249d13cdfd8d1e257fbade5a5c13c2aecb2 Mon Sep 17 00:00:00 2001 From: Miguel Angel Moreno Date: Mon, 1 Jul 2024 12:18:59 +0200 Subject: [PATCH 22/47] Add debug --- .github/workflows/ci.yml | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index b38da38..321229f 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -95,7 +95,10 @@ jobs: env: NODE_AUTH_TOKEN: ${{ secrets.GITHUB_TOKEN }} run: | - yarn config set 'npmRegistries["//npm.pkg.github.com"].npmAuthToken' "${NODE_AUTH_TOKEN}" + cat ~/.npmrc + yarn config set npmPublishRegistry "https://npm.pkg.github.com" + yarn config set npmAuthToken "${NODE_AUTH_TOKEN}" + - name: Publish release if: startsWith(github.ref, 'refs/tags/') From aa7bdfd9023e3307eebd2aba4531ff05bae41f8b Mon Sep 17 00:00:00 2001 From: Miguel Angel Moreno Date: Mon, 1 Jul 2024 12:28:44 +0200 Subject: [PATCH 23/47] Change package org --- .github/workflows/ci.yml | 1 - package.json | 2 +- 2 files changed, 1 insertion(+), 2 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 321229f..699a68a 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -95,7 +95,6 @@ jobs: env: NODE_AUTH_TOKEN: ${{ secrets.GITHUB_TOKEN }} run: | - cat ~/.npmrc yarn config set npmPublishRegistry "https://npm.pkg.github.com" yarn config set npmAuthToken "${NODE_AUTH_TOKEN}" diff --git a/package.json b/package.json index e6dd1b3..d82a427 100644 --- a/package.json +++ b/package.json @@ -1,5 +1,5 @@ { - "name": "@carto/api-client", + "name": "@cartodb/api-client", "version": "0.0.1-2", "publishConfig": { "access": "public", From 6b3df4c2e6a6d3bd1885a748401273cdd1695592 Mon Sep 17 00:00:00 2001 From: Miguel Angel Moreno Date: Mon, 1 Jul 2024 12:36:07 +0200 Subject: [PATCH 24/47] Revert "Change package org" This reverts commit aa7bdfd9023e3307eebd2aba4531ff05bae41f8b. --- .github/workflows/ci.yml | 1 + package.json | 2 +- 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 699a68a..321229f 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -95,6 +95,7 @@ jobs: env: NODE_AUTH_TOKEN: ${{ secrets.GITHUB_TOKEN }} run: | + cat ~/.npmrc yarn config set npmPublishRegistry "https://npm.pkg.github.com" yarn config set npmAuthToken "${NODE_AUTH_TOKEN}" diff --git a/package.json b/package.json index d82a427..e6dd1b3 100644 --- a/package.json +++ b/package.json @@ -1,5 +1,5 @@ { - "name": "@cartodb/api-client", + "name": "@carto/api-client", "version": "0.0.1-2", "publishConfig": { "access": "public", From 06755e840ef97c3307ccdf456771ae215817a9ba Mon Sep 17 00:00:00 2001 From: Miguel Angel Moreno Date: Mon, 1 Jul 2024 12:43:48 +0200 Subject: [PATCH 25/47] Add new token --- .github/workflows/ci.yml | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 321229f..c0ed85e 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -88,20 +88,20 @@ jobs: console.log(`Release type: ${releaseType}`) return releaseType - # This additional step is needed to configure the yarn auth token - # https://docs.github.com/en/actions/publishing-packages/publishing-nodejs-packages#publishing-packages-using-yarn - name: Configure yarn to publish if: startsWith(github.ref, 'refs/tags/') env: - NODE_AUTH_TOKEN: ${{ secrets.GITHUB_TOKEN }} + # The following token has been manually issued in the CartoDB + # organization for npmjs.com + NODE_AUTH_TOKEN: ${{ secrets.NPM_CARTODB_AUTH_TOKEN }} run: | - cat ~/.npmrc yarn config set npmPublishRegistry "https://npm.pkg.github.com" yarn config set npmAuthToken "${NODE_AUTH_TOKEN}" - - name: Publish release if: startsWith(github.ref, 'refs/tags/') env: - NODE_AUTH_TOKEN: ${{ secrets.GITHUB_TOKEN }} + # The following token has been manually issued in the CartoDB + # organization for npmjs.com + NODE_AUTH_TOKEN: ${{ secrets.NPM_CARTODB_AUTH_TOKEN }} run: yarn npm publish --tag ${{steps.get-release-type.outputs.result}} From 1a6ce081d6b8539f10341644f48fee3955770769 Mon Sep 17 00:00:00 2001 From: Miguel Angel Moreno Date: Mon, 1 Jul 2024 12:48:22 +0200 Subject: [PATCH 26/47] Add new token --- .github/workflows/ci.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index c0ed85e..7eb7429 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -95,7 +95,6 @@ jobs: # organization for npmjs.com NODE_AUTH_TOKEN: ${{ secrets.NPM_CARTODB_AUTH_TOKEN }} run: | - yarn config set npmPublishRegistry "https://npm.pkg.github.com" yarn config set npmAuthToken "${NODE_AUTH_TOKEN}" - name: Publish release @@ -104,4 +103,5 @@ jobs: # The following token has been manually issued in the CartoDB # organization for npmjs.com NODE_AUTH_TOKEN: ${{ secrets.NPM_CARTODB_AUTH_TOKEN }} - run: yarn npm publish --tag ${{steps.get-release-type.outputs.result}} + RELEASE_TYPE: ${{ steps.get-release-type.outputs.result }} + run: yarn npm publish --tag ${RELEASE_TYPE} From 7dbd81b68851283992bc219fda39e845468b2376 Mon Sep 17 00:00:00 2001 From: Miguel Angel Moreno Date: Mon, 1 Jul 2024 12:52:59 +0200 Subject: [PATCH 27/47] Change registry --- .github/workflows/ci.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 7eb7429..8607361 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -95,6 +95,7 @@ jobs: # organization for npmjs.com NODE_AUTH_TOKEN: ${{ secrets.NPM_CARTODB_AUTH_TOKEN }} run: | + yarn config set npmPublishRegistry "https://registry.npmjs.org/" yarn config set npmAuthToken "${NODE_AUTH_TOKEN}" - name: Publish release From df667e5adb978fe5dc8e8b49d96b531196776968 Mon Sep 17 00:00:00 2001 From: Miguel Angel Moreno Date: Mon, 1 Jul 2024 13:01:53 +0200 Subject: [PATCH 28/47] Create new version --- .github/workflows/ci.yml | 11 +++++++++-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 8607361..bb3f99e 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -88,7 +88,14 @@ jobs: console.log(`Release type: ${releaseType}`) return releaseType - - name: Configure yarn to publish + - name: Create the new package version + if: startsWith(github.ref, 'refs/tags/') + env: + RELEASE_TAG: ${{ steps.check-tag-format.outputs.version }} + run: | + yarn version --no-git-tag-version --new-version "${RELEASE_TAG}" + + - name: Configure yarn to publish packages if: startsWith(github.ref, 'refs/tags/') env: # The following token has been manually issued in the CartoDB @@ -98,7 +105,7 @@ jobs: yarn config set npmPublishRegistry "https://registry.npmjs.org/" yarn config set npmAuthToken "${NODE_AUTH_TOKEN}" - - name: Publish release + - name: Publish package if: startsWith(github.ref, 'refs/tags/') env: # The following token has been manually issued in the CartoDB From 0017fea0828549cadf3316321c21d9a9da668f1d Mon Sep 17 00:00:00 2001 From: Miguel Angel Moreno Date: Mon, 1 Jul 2024 13:06:53 +0200 Subject: [PATCH 29/47] Update tag --- .github/workflows/ci.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index bb3f99e..ccc797c 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -91,7 +91,7 @@ jobs: - name: Create the new package version if: startsWith(github.ref, 'refs/tags/') env: - RELEASE_TAG: ${{ steps.check-tag-format.outputs.version }} + RELEASE_TAG: ${{ steps.check-tag-format.outputs.full_without_prefix }} run: | yarn version --no-git-tag-version --new-version "${RELEASE_TAG}" From a6afd8fe1cbb362448fe670a63bd0d98c16c5218 Mon Sep 17 00:00:00 2001 From: Miguel Angel Moreno Date: Mon, 1 Jul 2024 13:16:57 +0200 Subject: [PATCH 30/47] Install yarn --- .github/workflows/ci.yml | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index ccc797c..55ab2a4 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -1,5 +1,8 @@ name: CI +env: + YARN_VERSION: 4.3.1 + on: push: # FIXME: @@ -41,6 +44,9 @@ jobs: - name: Enable Corepack run: corepack enable + - name: Install yarn + run: npm install -g yarn@${YARN_VERSION} + - name: Install run: yarn install From e56e205701c27d56a19408fb6166db7bf4f7c62a Mon Sep 17 00:00:00 2001 From: Miguel Angel Moreno Date: Mon, 1 Jul 2024 13:18:43 +0200 Subject: [PATCH 31/47] Install yarn --- .github/workflows/ci.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 55ab2a4..6878d8c 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -1,7 +1,7 @@ name: CI env: - YARN_VERSION: 4.3.1 + YARN_VERSION: v4.3.1 on: push: From 15ef2fdbb2efd461a427491c257d9763a0c0ae73 Mon Sep 17 00:00:00 2001 From: Miguel Angel Moreno Date: Mon, 1 Jul 2024 13:20:59 +0200 Subject: [PATCH 32/47] Install yarn --- .github/workflows/ci.yml | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 6878d8c..82f73a1 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -1,8 +1,5 @@ name: CI -env: - YARN_VERSION: v4.3.1 - on: push: # FIXME: @@ -44,8 +41,10 @@ jobs: - name: Enable Corepack run: corepack enable - - name: Install yarn - run: npm install -g yarn@${YARN_VERSION} + # - name: Install yarn + # run: | + # npm install -g yarn + # yarn --version - name: Install run: yarn install @@ -99,6 +98,7 @@ jobs: env: RELEASE_TAG: ${{ steps.check-tag-format.outputs.full_without_prefix }} run: | + yarn --version yarn version --no-git-tag-version --new-version "${RELEASE_TAG}" - name: Configure yarn to publish packages From 2987ff0cff1f49df6be80ee3b43fa63f240831d9 Mon Sep 17 00:00:00 2001 From: Miguel Angel Moreno Date: Mon, 1 Jul 2024 15:32:49 +0200 Subject: [PATCH 33/47] Update package version --- .github/workflows/ci.yml | 8 -------- package.json | 2 +- 2 files changed, 1 insertion(+), 9 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 82f73a1..6849641 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -93,14 +93,6 @@ jobs: console.log(`Release type: ${releaseType}`) return releaseType - - name: Create the new package version - if: startsWith(github.ref, 'refs/tags/') - env: - RELEASE_TAG: ${{ steps.check-tag-format.outputs.full_without_prefix }} - run: | - yarn --version - yarn version --no-git-tag-version --new-version "${RELEASE_TAG}" - - name: Configure yarn to publish packages if: startsWith(github.ref, 'refs/tags/') env: diff --git a/package.json b/package.json index e6dd1b3..e723da6 100644 --- a/package.json +++ b/package.json @@ -1,6 +1,6 @@ { "name": "@carto/api-client", - "version": "0.0.1-2", + "version": "v0.0.29", "publishConfig": { "access": "public", "tag": "alpha" From 934eab94b80b89a0033aa57bd8cc10d169227dc8 Mon Sep 17 00:00:00 2001 From: Miguel Angel Moreno Date: Mon, 1 Jul 2024 15:38:44 +0200 Subject: [PATCH 34/47] Update package version --- package.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/package.json b/package.json index e723da6..922a823 100644 --- a/package.json +++ b/package.json @@ -1,6 +1,6 @@ { "name": "@carto/api-client", - "version": "v0.0.29", + "version": "0.0.29", "publishConfig": { "access": "public", "tag": "alpha" From 636dd7c0fb7a25725c0e19dcab427eceee1aab03 Mon Sep 17 00:00:00 2001 From: Miguel Angel Moreno Date: Mon, 1 Jul 2024 15:39:17 +0200 Subject: [PATCH 35/47] Update package version --- package.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/package.json b/package.json index 922a823..a9aef0a 100644 --- a/package.json +++ b/package.json @@ -1,6 +1,6 @@ { "name": "@carto/api-client", - "version": "0.0.29", + "version": "0.0.30", "publishConfig": { "access": "public", "tag": "alpha" From 0d332e64a561cfb32e79ca159f3ab4656dfa9d64 Mon Sep 17 00:00:00 2001 From: Miguel Angel Moreno Date: Mon, 1 Jul 2024 15:47:21 +0200 Subject: [PATCH 36/47] Remove fixme --- .github/workflows/ci.yml | 41 +++++++++++++--------------------------- 1 file changed, 13 insertions(+), 28 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 6849641..8b62485 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -2,14 +2,11 @@ name: CI on: push: - # FIXME: - # branches: [main] - # branches: [feature/sc-420243/ci-configuration] + branches: [main] tags: [v*] - # pull_request: - # FIMXE: - # branches: [main] + pull_request: + branches: [main] jobs: build: @@ -18,9 +15,7 @@ jobs: strategy: matrix: - # FIXME: - # node-version: [18.x, 20.x, 22.x] - node-version: [18.x] + node-version: [18.x, 20.x, 22.x] env: CI: true @@ -29,9 +24,9 @@ jobs: - name: Checkout uses: actions/checkout@v4 - ### + ########################################################################## # Build - ### + ########################################################################## - name: Set up Node.js ${{ matrix.node-version }} uses: actions/setup-node@v4 @@ -41,28 +36,21 @@ jobs: - name: Enable Corepack run: corepack enable - # - name: Install yarn - # run: | - # npm install -g yarn - # yarn --version - - name: Install run: yarn install - name: Build run: yarn build - # FIXME: - - # - name: Lint - # run: yarn lint + - name: Lint + run: yarn lint - # - name: Test - # run: yarn test + - name: Test + run: yarn test - ### - # Release - ### + ########################################################################## + # Publish + ########################################################################## - name: Check tag format id: check-tag-format @@ -106,8 +94,5 @@ jobs: - name: Publish package if: startsWith(github.ref, 'refs/tags/') env: - # The following token has been manually issued in the CartoDB - # organization for npmjs.com - NODE_AUTH_TOKEN: ${{ secrets.NPM_CARTODB_AUTH_TOKEN }} RELEASE_TYPE: ${{ steps.get-release-type.outputs.result }} run: yarn npm publish --tag ${RELEASE_TYPE} From e1d112b0d5ea630309112ceda9acb45b85c4e81a Mon Sep 17 00:00:00 2001 From: Miguel Angel Moreno Date: Mon, 1 Jul 2024 15:48:07 +0200 Subject: [PATCH 37/47] Remove fixme --- package.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/package.json b/package.json index a9aef0a..9ef917a 100644 --- a/package.json +++ b/package.json @@ -1,6 +1,6 @@ { "name": "@carto/api-client", - "version": "0.0.30", + "version": "0.0.32", "publishConfig": { "access": "public", "tag": "alpha" From 82b964446c2a4b454d5fb51e0c8241f8bc62bc0c Mon Sep 17 00:00:00 2001 From: Miguel Angel Moreno Date: Mon, 1 Jul 2024 16:01:32 +0200 Subject: [PATCH 38/47] Remove fixme --- .github/workflows/ci.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 8b62485..c0f1591 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -5,8 +5,8 @@ on: branches: [main] tags: [v*] - pull_request: - branches: [main] + # pull_request: + # branches: [main] jobs: build: From c86073ba93bb4e82d8fdf35d9ce69a6909899ea7 Mon Sep 17 00:00:00 2001 From: Miguel Angel Moreno Date: Mon, 1 Jul 2024 16:03:38 +0200 Subject: [PATCH 39/47] Remove fixme --- .github/workflows/ci.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index c0f1591..8b62485 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -5,8 +5,8 @@ on: branches: [main] tags: [v*] - # pull_request: - # branches: [main] + pull_request: + branches: [main] jobs: build: From ede0311c6756344660cdc995b8bd791edcc4f056 Mon Sep 17 00:00:00 2001 From: Miguel Angel Moreno Date: Wed, 3 Jul 2024 08:24:11 +0200 Subject: [PATCH 40/47] Remove tag preffix --- .github/workflows/ci.yml | 22 +++++++++++++--------- 1 file changed, 13 insertions(+), 9 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 8b62485..c3d363d 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -3,7 +3,7 @@ name: CI on: push: branches: [main] - tags: [v*] + tags: [.*] pull_request: branches: [main] @@ -15,7 +15,13 @@ jobs: strategy: matrix: - node-version: [18.x, 20.x, 22.x] + include: + - node-version: 18.x + publish: false + - node-version: 20.x + publish: true # Publish on npm + - node-version: 22.x + publish: false env: CI: true @@ -54,17 +60,15 @@ jobs: - name: Check tag format id: check-tag-format - if: startsWith(github.ref, 'refs/tags/') + if: startsWith(github.ref, 'refs/tags/') && matrix.publish == 'true' uses: nowsprinting/check-version-format-action@v4 - with: - prefix: 'v' - name: Exit on invalid tag format - if: startsWith(github.ref, 'refs/tags/') && steps.check-tag-format.outputs.is_valid == 'false' + if: startsWith(github.ref, 'refs/tags/') && steps.check-tag-format.outputs.is_valid == 'false' && matrix.publish == 'true' run: echo "Tag must follow SemVer convention. Aborting." && exit 1 - name: Get release type - if: startsWith(github.ref, 'refs/tags/') + if: startsWith(github.ref, 'refs/tags/') && matrix.publish == 'true' id: get-release-type uses: actions/github-script@v7 with: @@ -82,7 +86,7 @@ jobs: return releaseType - name: Configure yarn to publish packages - if: startsWith(github.ref, 'refs/tags/') + if: startsWith(github.ref, 'refs/tags/') && matrix.publish == 'true' env: # The following token has been manually issued in the CartoDB # organization for npmjs.com @@ -92,7 +96,7 @@ jobs: yarn config set npmAuthToken "${NODE_AUTH_TOKEN}" - name: Publish package - if: startsWith(github.ref, 'refs/tags/') + if: startsWith(github.ref, 'refs/tags/') && matrix.publish == 'true' env: RELEASE_TYPE: ${{ steps.get-release-type.outputs.result }} run: yarn npm publish --tag ${RELEASE_TYPE} From d6150adb17f40ff48442ae5492c6cd2966e7828e Mon Sep 17 00:00:00 2001 From: Miguel Angel Moreno Date: Wed, 3 Jul 2024 08:24:29 +0200 Subject: [PATCH 41/47] Remove tag preffix --- package.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/package.json b/package.json index 9ef917a..c590281 100644 --- a/package.json +++ b/package.json @@ -1,6 +1,6 @@ { "name": "@carto/api-client", - "version": "0.0.32", + "version": "0.0.33", "publishConfig": { "access": "public", "tag": "alpha" From b9ee49b989442a78897e2ce3f2c9f44e21935d6b Mon Sep 17 00:00:00 2001 From: Miguel Angel Moreno Date: Wed, 3 Jul 2024 08:27:34 +0200 Subject: [PATCH 42/47] Remove tag preffix --- .github/workflows/ci.yml | 2 +- package.json | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index c3d363d..9bc8223 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -3,7 +3,7 @@ name: CI on: push: branches: [main] - tags: [.*] + tags: ['*'] pull_request: branches: [main] diff --git a/package.json b/package.json index c590281..4f24765 100644 --- a/package.json +++ b/package.json @@ -1,6 +1,6 @@ { "name": "@carto/api-client", - "version": "0.0.33", + "version": "0.0.34", "publishConfig": { "access": "public", "tag": "alpha" From cc1cb01dd63b6deb47c384e907793d252d95145e Mon Sep 17 00:00:00 2001 From: Miguel Angel Moreno Date: Wed, 3 Jul 2024 08:36:42 +0200 Subject: [PATCH 43/47] Remove tag preffix --- .github/workflows/ci.yml | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 9bc8223..2e93ea8 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -60,15 +60,15 @@ jobs: - name: Check tag format id: check-tag-format - if: startsWith(github.ref, 'refs/tags/') && matrix.publish == 'true' + if: startsWith(github.ref, 'refs/tags/') && matrix.publish uses: nowsprinting/check-version-format-action@v4 - name: Exit on invalid tag format - if: startsWith(github.ref, 'refs/tags/') && steps.check-tag-format.outputs.is_valid == 'false' && matrix.publish == 'true' + if: startsWith(github.ref, 'refs/tags/') && !steps.check-tag-format.outputs.is_valid && matrix.publish run: echo "Tag must follow SemVer convention. Aborting." && exit 1 - name: Get release type - if: startsWith(github.ref, 'refs/tags/') && matrix.publish == 'true' + if: startsWith(github.ref, 'refs/tags/') && matrix.publish id: get-release-type uses: actions/github-script@v7 with: @@ -86,7 +86,7 @@ jobs: return releaseType - name: Configure yarn to publish packages - if: startsWith(github.ref, 'refs/tags/') && matrix.publish == 'true' + if: startsWith(github.ref, 'refs/tags/') && matrix.publish env: # The following token has been manually issued in the CartoDB # organization for npmjs.com @@ -96,7 +96,7 @@ jobs: yarn config set npmAuthToken "${NODE_AUTH_TOKEN}" - name: Publish package - if: startsWith(github.ref, 'refs/tags/') && matrix.publish == 'true' + if: startsWith(github.ref, 'refs/tags/') && matrix.publish env: RELEASE_TYPE: ${{ steps.get-release-type.outputs.result }} run: yarn npm publish --tag ${RELEASE_TYPE} From 3062a1a5dbcfd343fa647416925c270d79ae812d Mon Sep 17 00:00:00 2001 From: Miguel Angel Moreno Date: Wed, 3 Jul 2024 08:36:50 +0200 Subject: [PATCH 44/47] Remove tag preffix --- package.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/package.json b/package.json index 4f24765..3613c78 100644 --- a/package.json +++ b/package.json @@ -1,6 +1,6 @@ { "name": "@carto/api-client", - "version": "0.0.34", + "version": "0.0.35", "publishConfig": { "access": "public", "tag": "alpha" From 3292a94e2c695508a32a3f305345deeefcfe651a Mon Sep 17 00:00:00 2001 From: Miguel Angel Moreno Date: Wed, 3 Jul 2024 13:05:14 +0200 Subject: [PATCH 45/47] Change CI order --- .github/workflows/ci.yml | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 2e93ea8..1dcceda 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -45,15 +45,15 @@ jobs: - name: Install run: yarn install - - name: Build - run: yarn build - - name: Lint run: yarn lint - name: Test run: yarn test + - name: Build + run: yarn build + ########################################################################## # Publish ########################################################################## From 6cd07c4708272c49257af0c938135e6cc40c17d9 Mon Sep 17 00:00:00 2001 From: Miguel Angel Moreno Date: Wed, 3 Jul 2024 13:06:29 +0200 Subject: [PATCH 46/47] Change CI order --- .github/workflows/ci.yml | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 1dcceda..20755f1 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -48,12 +48,12 @@ jobs: - name: Lint run: yarn lint - - name: Test - run: yarn test - - name: Build run: yarn build + - name: Test + run: yarn test + ########################################################################## # Publish ########################################################################## From 95334574b7968fa60f22714b003425cb1befc392 Mon Sep 17 00:00:00 2001 From: Miguel Angel Moreno Date: Mon, 15 Jul 2024 14:36:38 +0200 Subject: [PATCH 47/47] Skip on wrong tag set --- .github/workflows/ci.yml | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 20755f1..9ed0b94 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -85,6 +85,11 @@ jobs: console.log(`Release type: ${releaseType}`) return releaseType + # This may indicate that the tag set has a typo, e.g., alpah, betta, etc. + - name: Verify tag format + if: !steps.check-tag-format.outputs.is_stable && steps.get-release-type.outputs.result == 'latest' + run: echo "Tag set may be incorrect. Please, review" && exit 1 + - name: Configure yarn to publish packages if: startsWith(github.ref, 'refs/tags/') && matrix.publish env: