Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Admin can approve and reject submissions #3

Closed
MathyouMB opened this issue May 27, 2024 · 0 comments · Fixed by #12
Closed

Admin can approve and reject submissions #3

MathyouMB opened this issue May 27, 2024 · 0 comments · Fixed by #12
Assignees
Labels
enhancement New feature or request

Comments

@MathyouMB
Copy link
Member

MathyouMB commented May 27, 2024

As a admin, I should be able to review submissions as either approved or rejected.

Implement the approved and rejected methods. Both should create a row in the reviews table. The status of a review "approve / rejected" should be represented as a enum.

We have not implemented "judges" or admins yet, so do not worry about who can access these methods.

Fill in the create method on this file: app/challenges-platform/services/reviews-service.ts leave the TODO comment (don't worry about that check now)

AC:

  • implement approved and rejected
  • add jest tests for both
@MrRibcage MrRibcage self-assigned this May 28, 2024
@MrRibcage MrRibcage moved this from Todo to In Progress in Summer 2024 Open Source Contributions May 29, 2024
@MrRibcage MrRibcage linked a pull request Jun 11, 2024 that will close this issue
@MrRibcage MrRibcage moved this from Assigned - In Progress to For Review - Completed in Summer 2024 Open Source Contributions Jun 12, 2024
@ryangchung ryangchung added the enhancement New feature or request label Jun 17, 2024
@AJaccP AJaccP moved this from For Review - Completed to Done - Merged in Summer 2024 Open Source Contributions Jun 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
No open projects
Status: Done - Merged
Development

Successfully merging a pull request may close this issue.

3 participants