Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature request: custom nonce #15

Open
reslear opened this issue Oct 3, 2024 · 7 comments
Open

feature request: custom nonce #15

reslear opened this issue Oct 3, 2024 · 7 comments

Comments

@reslear
Copy link
Contributor

reslear commented Oct 3, 2024

implement feature for setting custom nonce:

google/GoogleSignIn-iOS#402
or https://developer.android.com/identity/sign-in/credential-manager-siwg#set-nonce

// draft 
const res = await SocialLogin.login({
  provider: 'google',
  options: {
    scopes: ['email', 'profile'],
    nonce: 'ABCD'
  },
});
@riderx
Copy link
Contributor

riderx commented Oct 4, 2024

Nonce i can add :)

@riderx
Copy link
Contributor

riderx commented Oct 4, 2024

It's not release yet on IOS : https://developers.google.com/identity/sign-in/ios/release
I Added in on android

@reslear
Copy link
Contributor Author

reslear commented Oct 4, 2024

good, we'll be waiting ios release)

@riderx
Copy link
Contributor

riderx commented Oct 4, 2024

Trying my best to release, but Facebook fucked their SDK

@reslear
Copy link
Contributor Author

reslear commented Oct 4, 2024

@riderx also need implement Limited login for fb...

fb is 🤮 I have to rewrite the entire approach on ios because of the facebook latest Data Protection Assessment :)

@riderx
Copy link
Contributor

riderx commented Oct 4, 2024

not sure to what you mean can you share doc?

@reslear
Copy link
Contributor Author

reslear commented Oct 4, 2024

@riderx I think it would attract people since it's a popular issue capacitor-community/facebook-login#150

ok i create new issue #17

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants