Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compilation of trash feature fails on darwin #887

Open
Schweber opened this issue Jun 7, 2024 · 3 comments
Open

Compilation of trash feature fails on darwin #887

Schweber opened this issue Jun 7, 2024 · 3 comments
Labels
enhancement New feature or request Mac

Comments

@Schweber
Copy link
Contributor

Schweber commented Jun 7, 2024

The compilation of broot on x86_64_darwin fails with

error[E0433]: failed to resolve: could not find `os_limited` in `trash`
   --> src/app/panel_state.rs:162:34
    |
162 |                 let res = trash::os_limited::list()
    |                                  ^^^^^^^^^^ could not find `os_limited` in `trash`
    |
note: found an item that was configured out
   --> /private/tmp/nix-build-broot-1.39.0.drv-0/broot-1.39.0-vendor.tar.gz/trash/src/lib.rs:350:9
    |
350 | pub mod os_limited {
    |         ^^^^^^^^^^
error[E0433]: failed to resolve: could not find `os_limited` in `trash`
   --> src/app/panel_state.rs:164:32
    |
164 |                         trash::os_limited::purge_all(items)
    |                                ^^^^^^^^^^ could not find `os_limited` in `trash`
    |
note: found an item that was configured out

In the readme of trash it says:

The library supports Windows, macOS, and all FreeDesktop Trash compliant environments (including GNOME, KDE, XFCE, and more).

Is there something that can be done about it? I would like to enable trash as the default build Feature in nixpkgs.

@Schweber Schweber added the bug Something isn't working label Jun 7, 2024
@Canop
Copy link
Owner

Canop commented Jun 7, 2024

This README is misleading IMO: all the interesting features like listing the content of the trash or purging it are implemented only for Linux and Windows. See https://docs.rs/trash/latest/trash/os_limited/index.html

If somebody finds another crate, or implements the missing features, we could make them available in broot but I can't really work on Mac specific things as I don't own a Mac.

@Canop Canop removed the bug Something isn't working label Jun 7, 2024
@Schweber
Copy link
Contributor Author

Schweber commented Jun 7, 2024

I see, thank you for looking into it!

@Schweber Schweber closed this as not planned Won't fix, can't repro, duplicate, stale Jun 7, 2024
@Canop Canop added Mac enhancement New feature or request labels Jun 7, 2024
@Canop
Copy link
Owner

Canop commented Jun 7, 2024

Reopening, because adding trash features on Mac is a valid issue, even if I can't work alone on it

@Canop Canop reopened this Jun 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Mac
Projects
None yet
Development

No branches or pull requests

2 participants