Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Paths instruction and extension #96

Open
mbkiss opened this issue May 10, 2024 · 1 comment
Open

Paths instruction and extension #96

mbkiss opened this issue May 10, 2024 · 1 comment

Comments

@mbkiss
Copy link
Contributor

mbkiss commented May 10, 2024

I think it would be recommendable to write a short instruction on how to set up LION with changed paths:

Install conda environment

wget https://repo.continuum.io/miniconda/Miniconda3-latest-Linux-x86_64.sh -O conda.sh
bash conda.sh

Set up LION from own github fork on the gpu-server

git clone https://github.com/_CambridgeCIA_/LION.git (_or your own fork_)
cd LION
git submodule update --init --recursive
conda env create --file=env.yml
pip install git+https://github.com/ahendriksen/ts_algorithms.git **(because it fails before)**
conda activate LION

Change the paths in LION/LION/utils/paths.py and then move back to LION/ base
pip install -e .
Run the download.py file in LION/LION/data_loaders/2DeteCT/

  1. Maybe the paths in paths.py can be even set by default in reference to the installation folder
  2. In addition, I think it should include a path parameter for saving trained models and one for saving evaluations
  3. The last two mentioned paths could then be used in the standard templates for benchmarking and evaluation

This streamlines the individual usage of the toolbox where you only need to change a path in one location and not in many files.

@AnderBiguri
Copy link
Member

100 agree!

I am hoping that we can have something like pip install -e , -path:"somepath", or something like this in the future, but this is good info in the meanwhile!

Your extra points are also noted, may be the way to go. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants