Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more default parameters to deteCT #81

Open
AnderBiguri opened this issue Mar 19, 2024 · 0 comments
Open

Add more default parameters to deteCT #81

AnderBiguri opened this issue Mar 19, 2024 · 0 comments
Assignees

Comments

@AnderBiguri
Copy link
Member

AnderBiguri commented Mar 19, 2024

Currently the default settings for deteCT are to do a sino2recon in mode2:

def default_parameters():

It would be interesting to have more default parameters, such as

@staticmethod
def default_denoising_parameters():
    ....
@staticmethod
def default_beam_hardening_parameters():
    ....

That automatically give you a dataset with a standard config. Note: I would not change the geometry here, this is for Experiments classes. These parameters are only to define what is loaded in (input,target) pairs.

One thus could do in their code:

from LION.data_loaders.deteCT import deteCT

dataset = deteCT('training') # this loads default parameters
dataset = deteCT('training',parameters=deteCT.default_parameters()) #equivalent to the above

dataset = deteCT('training', parameters=deteCT.default_denoising_parameters()) # example of new default setting)

This could be even extended to the Experiment class. Currently, when you define a new Experiment, at some point you do Experiment.get_dataset_parameters(dataset_name) and this returns default parameters. We could modify this functions:

def get_dataset_parameters(dataset, geo=None):

to return specific default parameters. Or alternatively, new defined Experiments can directly only support certain datasets, e.g. deteCT and replace Experiment.get_dataset_parameters(dataset_name) with deteCT.default_denoising_parameters() for example.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants