Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unnecessary line in calyptus-hill test #1

Open
olegsinavski opened this issue Feb 19, 2023 · 0 comments
Open

Unnecessary line in calyptus-hill test #1

olegsinavski opened this issue Feb 19, 2023 · 0 comments

Comments

@olegsinavski
Copy link

Hello, in the calyptus-hill.js test, in the after function we can see the following code:

    bribe = await this.calyptusHill.bribe();

    if (
      expect(await this.calyptusHill.atTheTop()).not.to.equal(alice.address)
    ) {
      console.log(`You have passed the ${challengeName}.`);
    }

Am I right that bribe = await this.calyptusHill.bribe(); doesn't do anything? Afterall, its just a getter and I don't think it can influence the success of the condition below

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant