Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split Fabric Rendering API support code into an optional module #2900

Open
jellysquid3 opened this issue Dec 2, 2024 · 3 comments
Open

Split Fabric Rendering API support code into an optional module #2900

jellysquid3 opened this issue Dec 2, 2024 · 3 comments
Assignees
Labels
T-tracking Type: Tracking

Comments

@jellysquid3
Copy link
Member

jellysquid3 commented Dec 2, 2024

Right now, the development of Sodium for Minecraft 1.21.4 is blocked on upstream's port of Fabric Rendering API. We need to find a way to make this dependency optional so that we can get unblocked and avoid delays in the future.

The work involved to do this looks to be significant, and there is no way it can be done in the next day. As a stop-gap solution, we may need to distribute a patched version of the upstream module so that we can release on time.

To be clear, the goal is simply to make it so that Fabric integration is not required for our team to work on a prototype port of the mod. We don't plan to change our stance regarding Fabric API support whatsoever.

@jellysquid3 jellysquid3 added P-high Priority: High P-critical Priority: The issue is of critical importance and removed P-high Priority: High labels Dec 2, 2024
@jellysquid3 jellysquid3 self-assigned this Dec 2, 2024
@jellysquid3
Copy link
Member Author

jellysquid3 commented Dec 2, 2024

Fabric API has a very large outstanding pull request (FabricMC/fabric#4247) that is being actively updated, which Sodium is currently targeting in a snapshot branch. But there were some breaking changes made today that we still need to adapt for, and there are not yet any reviews.

@jellysquid3 jellysquid3 added the T-tracking Type: Tracking label Dec 2, 2024
@jellysquid3
Copy link
Member Author

Pepper let me know that they are expecting to be able to merge the pull request today, which would unblock things.

@jellysquid3
Copy link
Member Author

Fabric API 0.110.5 has been released, which should allow us to complete our port. I will reduce the priority of this issue as a result.

@jellysquid3 jellysquid3 removed the P-critical Priority: The issue is of critical importance label Dec 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T-tracking Type: Tracking
Projects
None yet
Development

No branches or pull requests

1 participant