Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quad ordering is incorrect after material downgrading, causing problems with certain block models #2868

Open
joe-vettek opened this issue Nov 6, 2024 · 6 comments
Labels
A-resource-packs Area: Resource packs P-high Priority: High T-bug Type: Bug
Milestone

Comments

@joe-vettek
Copy link

Bug Description

In vanilla MC, Mojang allowed modders to overlay textures by means of isotropic blocks, without being affected by z-depth.
An example is the grass block model, which makes layered tinting possible and more flexible.
However, in Sodium, although side coverage is still supported, There is a weird sorting problem here.
image
image

Reproduction Steps

  1. open minecraft and use version 1.21.1
  2. use Sodium
  3. use the test resourcepack
    TESTPack.zip
  4. place oak leaves or blue stained glass

Log File

None log, because it not crash.
debug.log

Crash Report

crash-2024-11-06_12.14.25-client.txt

@joe-vettek joe-vettek added the S-needs-triage Status: Needs triage label Nov 6, 2024
@jellysquid3
Copy link
Member

Does this issue happen without Iris?

@douira
Copy link
Collaborator

douira commented Nov 6, 2024

I can reproduce without Iris on dev

@douira
Copy link
Collaborator

douira commented Nov 6, 2024

For reference, the result vanilla produces is oak leaves that look like a snow block.

Screenshot 2024-11-06 at 05 27 31
The model is the following:

{
  "parent": "block/block",
  "textures": {
    "particle": "block/oak_leaves",
    "all": "block/oak_leaves",
    "1": "block/snow"
  },
  "elements": [
{
    "from": [0, 0, 0],
    "to": [16, 16, 16],
    "faces": {
      "north": {"uv": [0, 0, 16, 16], "texture": "#all", "cullface": "north", "tintindex": 0},
      "east": {"uv": [0, 0, 16, 16], "texture": "#all", "cullface": "east", "tintindex": 0},
      "south": {"uv": [0, 0, 16, 16], "texture": "#all", "cullface": "south", "tintindex": 0},
      "west": {"uv": [0, 0, 16, 16], "texture": "#all", "cullface": "west", "tintindex": 0},
      "up": {"uv": [0, 0, 16, 16], "texture": "#all", "cullface": "up", "tintindex": 0},
      "down": {"uv": [0, 0, 16, 16], "texture": "#all", "cullface": "down", "tintindex": 0}
    }
  },{
      "from": [0, 0, 0],
      "to": [16, 16, 16],
      "faces": {
        "north": {"uv": [0, 0, 16, 16], "texture": "#1", "cullface": "north"},
        "east": {"uv": [0, 0, 16, 16], "texture": "#1", "cullface": "east"},
        "south": {"uv": [0, 0, 16, 16], "texture": "#1", "cullface": "south"},
        "west": {"uv": [0, 0, 16, 16], "texture": "#1", "cullface": "west"},
        "up": {"uv": [0, 0, 16, 16], "texture": "#1", "cullface": "up"}
      }
    }]
}

@douira
Copy link
Collaborator

douira commented Nov 6, 2024

Possibly related to #2810?

@joe-vettek
Copy link
Author

Possibly related to #2810?

i think yes, but not need Continuity

@joe-vettek
Copy link
Author

@jellysquid3 yes, iris is not need in fact

@jellysquid3 jellysquid3 added A-resource-packs Area: Resource packs T-bug Type: Bug P-high Priority: High and removed S-needs-triage Status: Needs triage labels Nov 12, 2024
@jellysquid3 jellysquid3 changed the title Sodium has incorrectly enforced ordering for texture overrides of block model. Quad ordering is incorrect after material downgrading, causing problems with certain block models Nov 12, 2024
@douira douira added this to the Sodium 0.6 milestone Nov 12, 2024
@jellysquid3 jellysquid3 modified the milestones: Sodium 0.6, Sodium 0.6.1 Nov 17, 2024
@jellysquid3 jellysquid3 modified the milestones: Sodium 0.6.1, Sodium 0.6.2 Dec 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-resource-packs Area: Resource packs P-high Priority: High T-bug Type: Bug
Projects
None yet
Development

No branches or pull requests

3 participants