Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace Prime classes with props #111

Open
tysky opened this issue Oct 13, 2022 · 0 comments
Open

Replace Prime classes with props #111

tysky opened this issue Oct 13, 2022 · 0 comments

Comments

@tysky
Copy link
Contributor

tysky commented Oct 13, 2022

For some components Prime uses html classes instead of React props. But this approach confuses and couples an application to Prime framework.
It would be nice to write

<Button label="Secondary" type="secondary" />

instead of

<Button label="Secondary" className="p-button-secondary" />

We should research Sphere-UI components for such html classes and replace them with React props.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant