Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mesa: Improve RT performance in RADV driver and fix DEQP crash #370

Merged
merged 2 commits into from
Oct 11, 2024

Conversation

1Naim
Copy link
Member

@1Naim 1Naim commented Oct 3, 2024

Cherrypick 2 patches that improve performance in general and when ray tracing respectively.

These 2 patches [1] [2] were cherry picked in response to my comment I made #328 (comment).

Edit:
The first patch doesn't seem to do anything so I'm just going to cherrypick the 2nd one as it fixes wayland sessions crashing too x).

@1Naim 1Naim changed the title mesa: 24.2.4 mesa/vk: Cherrypick patches to improve performance Oct 3, 2024
@1Naim 1Naim force-pushed the bump/mesa branch 2 times, most recently from e2bb7a7 to e69ea87 Compare October 3, 2024 16:53
@ms178
Copy link

ms178 commented Oct 3, 2024

Just FYI, the second one got merged into mesa-git an hour ago. You might also take a look at 28973 and 20275. As CachyOS adopted zlib-ng and also compiles with march, both might yield some benefits. I've used these both locally for some time.

@1Naim
Copy link
Member Author

1Naim commented Oct 3, 2024

28973: We don't need to cherry-pick this because we are already using zlib-ng-compat.

20275: I'm hesitant on adding a closed PR, but I'll look into it tomorrow as there is a chance this has been merged in the form of another MR.

@ptr1337
Copy link
Member

ptr1337 commented Oct 3, 2024

Just FYI, the second one got merged into mesa-git an hour ago. You might also take a look at 28973 and 20275. As CachyOS adopted zlib-ng and also compiles with march, both might yield some benefits. I've used these both locally for some time.

One got closed, the other is still drafted

@ptr1337
Copy link
Member

ptr1337 commented Oct 3, 2024

28973: We don't need to cherry-pick this because we are already using zlib-ng-compat.

Native zlib-ng is faster tho. But yeah, as long its a draft wont happen

@ms178
Copy link

ms178 commented Oct 3, 2024

Just FYI, the second one got merged into mesa-git an hour ago. You might also take a look at 28973 and 20275. As CachyOS adopted zlib-ng and also compiles with march, both might yield some benefits. I've used these both locally for some time.

One got closed, the other is still drafted

I wouldn't derive too much from the status alone. Marek closed it because he didn't want to put much more time into it, the MR is still useful though on what it brings to the table, especially since CachyOS would make use of that code path.

@1Naim
Copy link
Member Author

1Naim commented Oct 4, 2024

These 2 patches [1] [2] were cherry picked in response to my comment I made #328 (comment).

These 2 patches are now merged upstream. It should be relatively safe to cherry-pick them here.

I've also cherrypicked another patch that fixes a DEQP that will likely be backported to 24.2 branch as the regression also affects this branch.

@1Naim 1Naim marked this pull request as ready for review October 4, 2024 04:07
According to the MR, this should bring RT performance on RADV to equal to AMDVLK, atleast on a RDNA2 card.

Signed-off-by: Eric Naim <[email protected]>
Signed-off-by: Eric Naim <[email protected]>
@1Naim 1Naim changed the title mesa/vk: Cherrypick patches to improve performance mesa: Improve RT performance in RADV driver Oct 4, 2024
@1Naim 1Naim changed the title mesa: Improve RT performance in RADV driver mesa: Improve RT performance in RADV driver and fix DEQP crash Oct 4, 2024
@1Naim 1Naim requested a review from ptr1337 October 4, 2024 17:34
@ptr1337 ptr1337 merged commit 5d45971 into master Oct 11, 2024
@ptr1337 ptr1337 deleted the bump/mesa branch October 11, 2024 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants