You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I'm using /warnaserror msbuild switch to enable warnings as errors.
Currently, the messages about the bindings are warnings and the switch turns them into red error.
<WarningCondition="'$(GeneratedBindingRedirectsAction)' == 'Overwrite'"File="Web.config"Text="Generated Binding Redirects have been applied automatically to the Web.config. This warning will disappear on the next build." />
Proposals:
Replace them with Messages
Add custom Code to Warnings so people can suppress them.
Messages with high importance would be a better joice but let me know. I'm happy to send a PR with either change.
The text was updated successfully, but these errors were encountered:
@Yozer I don't think messages can include a file reference for 1 thing, and it is a warning - that the source was modified by the build process and that you may need to execute the build again for a 'clean' compile.
I certainly agree that adding a code to the warning would not be a bad thing to do, to allow sorting and, in your case, supressing the error.
If you are doing a PR, please take into account the open PR #61 which will move the warnings etc.
If you base your change off that PR, I will pull them both in on the next release.
@CZEMacLeod thanks for the response.
Having code on the warning would also work.
It's just adding one line to the Warning task: Code="WHAT123"
I'm not sure what prefix would be best there. Same code for all the warnings?
@Yozer I think each warning should be different. Indeed, the whole project should ensure we have messages, but that might have to be a separate issue/pr.
I think the code prefix should be SWSDK (for System.Web SDK) but if you have a better/different idea, I'm open to suggestions.
For these can we go with 100-10x for the codes. (I think there are 3 messages in the binding redirects section).
It might be useful to add the information to the docs to make it easier to search for the code too.
I'm using
/warnaserror
msbuild switch to enable warnings as errors.Currently, the messages about the bindings are warnings and the switch turns them into red error.
Proposals:
Messages with high importance would be a better joice but let me know. I'm happy to send a PR with either change.
The text was updated successfully, but these errors were encountered: