Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

5.1.0 accepts an object (instead of a string) for source.discovery #261

Open
ElectricNroff opened this issue Dec 14, 2023 · 1 comment
Open
Labels
enhancement New feature or request section:source Schema location is source

Comments

@ElectricNroff
Copy link

At the 2023-12-14 TWG meeting, the discussion suggested that, during testing of the 5.1.0 schema, any CVE Record that validated even though the record format was not "intended" would be considered a "loophole."

It might not be intended that CVE Records use source.discovery in a different way than Vulnogram.

Vulnogram, by default, inserts "source": { "discovery": "UNKNOWN" } into a CVE Record.

minimal/plausible test case (the CNA chooses to specify a language for the word "UNKNOWN")

{"dataType":"CVE_RECORD","dataVersion":"5.1","cveMetadata":{"cveId":"CVE-2025-0001",
"assignerOrgId":"b3476cb9-2e3d-41a6-98d0-0f47421a65b6","state":"PUBLISHED"},
"containers":{"cna":{"providerMetadata":{"orgId":"b3476cb9-2e3d-41a6-98d0-0f47421a65b6"},
"affected":[{"vendor":"v","product":"p",
"versions":[{"version":"1","status":"affected"}],
"defaultStatus":"affected"}],
"source":{"discovery":{"lang":"en","value":"UNKNOWN"}},
"descriptions":[{"lang":"en","value":"d"}],"references":[{"url":"https://a.ai"}]}}}

This is similar to #212 but does not require an x_ field. A possible solution is to require source.discovery to have a string value (not allow an object), so that all CVE Records are structurally consistent with how Vulnogram uses the source.discovery field.

@sei-vsarvepalli
Copy link
Contributor

also related to #339

@jayjacobs jayjacobs added enhancement New feature or request section:source Schema location is source labels Nov 7, 2024
@ccoffin ccoffin added this to the CVE Record JSON Format v5.2.0 milestone Nov 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request section:source Schema location is source
Projects
None yet
Development

No branches or pull requests

4 participants