Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Potential bug of hyperboloid frechet mean #4

Open
ljxw88 opened this issue Jul 14, 2022 · 0 comments
Open

Potential bug of hyperboloid frechet mean #4

ljxw88 opened this issue Jul 14, 2022 · 0 comments

Comments

@ljxw88
Copy link

ljxw88 commented Jul 14, 2022

Applying frechet mean on the Lorentz model with K not equal to -1 cannot get the correct answer.

I found the bug in frechetmean/forward/hyperboloid_forward.py. Where the original code calculate variable mu with
mu = u / torch.sqrt(K * Lorentz._ldot(u, u, keepdim=True))

Changing it to
mu = - K * u / torch.sqrt(K * Lorentz._ldot(u, u, keepdim=True))
solves the problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant