Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cwd slider: line breaks in caption field will break the slide #51

Open
dc774 opened this issue Nov 19, 2021 · 3 comments
Open

cwd slider: line breaks in caption field will break the slide #51

dc774 opened this issue Nov 19, 2021 · 3 comments
Labels
bug Something isn't working

Comments

@dc774
Copy link
Contributor

dc774 commented Nov 19, 2021

Including a line break in the caption field (or either heading field) will break the image array and break the slide.

Slack discussion here.

Console error: "Uncaught SyntaxError: Invalid or unexpected token"

Screen Shot 2021-11-19 at 8 43 52 AM

@alisonjo315
Copy link
Member

Oh, fascinating that it's happening on WP, too -- thank you @dc774!

@alisonjo315 alisonjo315 added the bug Something isn't working label Nov 19, 2021
@ama39
Copy link
Collaborator

ama39 commented Aug 4, 2023

Reviewed in DUX Meeting:

There are a few ways we can approach this:

  1. Error-handling can be added to the JavaScript front-end.
  2. Error-handling can be added to the templates in Drupal and WordPress
  3. The JavaScript array can be abandoned in favor of a different data format (perhaps in addition to number 1 or 2).

The error-handing would need to convert line breaks to HTML <br> tags. There is also a related matter with quotes being passed to the array, breaking the array structure. So that should be looked at as well.

When time allows, this issue can be assigned to @ama39 and developers for Drupal and WordPress.

@alisonjo315
Copy link
Member

Yay, thanks for discussing! -- it's squishy how to handle issue statuses, y'all can decide what works for you (in theory, you could move it to "team review: done" because it's ready for the next step, which doesn't require team discussion -- and, it can always be added back to a review queue if there's another point of discussion) (BUT, y'all can manage your queue however you wish).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants