Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop using django.contrib.sites #369

Open
stefanor opened this issue Aug 11, 2017 · 4 comments
Open

Stop using django.contrib.sites #369

stefanor opened this issue Aug 11, 2017 · 4 comments

Comments

@stefanor
Copy link
Member

It's annoying, and we never put more than one conference in an install.

Let's just go with CONFERENCE_NAME in settings, and get rid of our use of the sites framework.

@hodgestar
Copy link
Member

Isn't sites required for generating absolute URLs?

@stefanor
Copy link
Member Author

Right. It isn't in normal cases, but it is in things that happen outside an http request/response cycle (e.g. batch emails)

@hodgestar
Copy link
Member

Would static site generation need this?

I'm not against removing django.contrib.sites -- it is an annoying extra step during set up -- just trying to think about things we'd need to fix.

@drnlm
Copy link
Member

drnlm commented Aug 12, 2017

The static site generation doesn't need django.contrib.sites out the box - it tries to generate relative links everywhere. Some of our renderers may use it (I haven't checked), but those should be easy to fix.

We have at least the following bits that currently require django.contrib.sites:

  • The registration emails - most of these should be simple to change.
  • Schedule uses the WAFER_CONFERENCE_ constants in several places, which are set from the site values. We'll need to check that we don't also use sites directly anywhere in the schedule as well.
  • The contrib.redirects package, which has been useful to PyConZA a couple of time, requires sites support to be enabled. This is looks the hardest to fix, and we'll probably have to reimplement some bits to make it work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants