Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nav.html should be easier to modify / extend #236

Open
drnlm opened this issue Apr 12, 2016 · 1 comment
Open

nav.html should be easier to modify / extend #236

drnlm opened this issue Apr 12, 2016 · 1 comment

Comments

@drnlm
Copy link
Member

drnlm commented Apr 12, 2016

Both debconf (https://anonscm.debian.org/cgit/debconf-data/dc16.dc.o.git/tree/templates/wafer/nav.html) and the latest pyconza2016 facelift pull request have ended up completely copying nav.html for fundamentally minor changes. This seems far from ideal, and we should to revisit how nav.html is structured so this isn't required.

It's not clear to me how best to address this. Possibly we need to split the innermost bits (such as the loop creating the main menu list and the dropdown menu logic) into sub-templates that are included, or add several more blocks so people can use block.super rather than having everyone duplicate that logic.

@zoidyzoidzoid
Copy link
Contributor

I guess semi-related, we want to make it easier for people to customise the menus and nav, so I guess that fits in to this ticket too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants