Move Byrnes' parallel OptSched to main repo #182
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- LLVM 15.0.0 library changes - Updated hardcoded register names
- `PriorityList::BoostEntry` can call `LinkedList::RmvEntry_`, removing the head of the priority list without correctly setting `wasTopRmved_` flag - This can lead to other methods incorrectly handling a null `rtrvEntry_`, as null checks depend on `wasTopRmved_`, leading to a crash - Changes include adding correct flag setting directly to `LinkedList::RmvEntry_` and asserts to methods that previously didn't handle a null `rtrvEntry_`.
jrbyrnes
reviewed
Aug 27, 2024
jrbyrnes
reviewed
Aug 29, 2024
jrbyrnes
reviewed
Aug 29, 2024
jrbyrnes
reviewed
Aug 29, 2024
jrbyrnes
reviewed
Aug 29, 2024
|
I still think we should bring back UnitTest infrastructure, but that is separate work |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mainly adds changes made by @jrbyrnes personal repo to the main repo's parallel BnB branch
This also includes some work on upgrading ROCm 4.5.2 to 5.4.1.
This also addresses a missed edge case in the custom linked list implementation