-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature: support running the app under a base URL #3363
Comments
Hi, |
Thanks @meericsc ; I don't have experience in clj or single page apps but I will take a run at a PR. Can you very briefly describe the changes you think that will be required in which components? Just a single sentence description for each would be great, e.g.
A follow-up question — looking at the current codebase it seems there is some code around |
Here is a rough overview. This is actually a REMS 2, and originally REMS 2 was a server-side application, not a single-page app. Then all the URLs were generated in the backend, so there were likely also more references to The problem is multifaceted. First of all the backend, which does less URL manipulation, must be updated to respond to basically all requests within the new "app path context" and not any others (to not require a separate router in front of REMS). Then the larger part of the problem is in the front-end URL routes and generating URLs.
It could be worth it to just try it out and report findings, but I think the road is going to be quite long and bumpy, unfortunately. |
Thank you @Macroz for the background and detailed description. I'll have a go at this. |
Is your feature request related to a problem? Please describe.
Related issue: #3356
I would like to host REMS under a non-root URL e.g.
https://my.domain/app1/
so that I may use path-based routing to gather related services under the same domain. This greatly simplifies sso and other shared origin requirements.My reading and experiments lead me to think that currently I can't do this because REMS is a single-page app that doesn't support a non-base URL configuration. I have tried reverse proxy config in front but it is not sufficient because using e.g.
nginx
sub_filter
or Apachemod_proxy_html
can only rewrite paths that appear explicitly in responses and not the application paths dynamically generated in script.Describe the solution you'd like
I would like a configuration point
base-url
that defaults to/
but can be changed to something else e.g./app1/
, so that the REMS application paths are all relative to that base URL.Describe alternatives you've considered
I have tried a reverse proxy. The best I can get REMS to work with is a proxy to a different port and/or subdomain, but not a new base path.
Additional context
Thanks for creating and maintaining REMS. It's a great product.
The text was updated successfully, but these errors were encountered: