Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

image add. Sorry for the delay #99

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Conversation

bsp2569
Copy link

@bsp2569 bsp2569 commented Jun 2, 2022

No description provided.

@vercel
Copy link

vercel bot commented Jun 2, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
csoc-22-week0-namecards ✅ Ready (Inspect) Visit Preview Jun 2, 2022 at 2:56AM (UTC)
csoc-week0-namecards ✅ Ready (Inspect) Visit Preview Jun 2, 2022 at 2:56AM (UTC)

Copy link
Collaborator

@debarati-06 debarati-06 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is not considered a good practice for making more than one Pull Request for the same task, instead add your changes to the same Pull request.

Eating
<lord-icon src="https://cdn.lordicon.com/jpdtnwas.json" trigger="loop" colors="primary:#121331,secondary:#e88c30" style="width:25px;height:25px"></lord-icon>
</div>
`,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maintain proper indentation.

{
handle_name: 'bsp2569',
name: "Bhabani Shankar Panigrahi",
image: "Passport size photo.jpeg",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Image path is still incorrect. Also use a image name without spaces
Path should be /images/file_name.jpg

@debarati-06 debarati-06 added the pending changes requested changes in the pull request label Jun 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pending changes requested changes in the pull request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants