-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clarify use of _type.purpose Key and Link #367
Comments
I fully agree that there is a need for some clarification, but are the purposes really redundant? I guess the status of an item being a
Seems sound. Do you suggest that this change is made automatically by the software or should we change the existing dictionaries to conform to this rule (I guess that majority of them already do)?
I guess that this extension is needed for the merged datasets? I do not object to the change, but currently there seem to be only two scenarios where composite keys are (properly) used:
|
@vaitkus's logic is impeccable. Let us leave the
We should change the dictionaries, if necessary, to conform to this rule. I believe that they should already conform, and if there are places that they don't we should check that we haven't overlooked something. |
Some data names may plausibly have purpose of both
Link
andKey
, if they are a foreign key that is also a key data name of the category. Note that both these purposes are redundant information as this information can be determined from other attributes. Therefore we just need to decide on a rule for assigning_type.purpose
, and it won't have any semantic consequences.I suggest that
Link
overrulesKey
, so that a key data name that is a link to another data name has_type.purpose
ofLink
.Also, as currently written a
Key
data name has to have a unique value, suggesting that it is the single key data name for the category. This purpose would obviously change if new key data names are added, so I suggest that we adjust the ddl description ofKey
purpose to state that this data name is one of the category key data names.The text was updated successfully, but these errors were encountered: