Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make GDAL dependency optionnal and raise error in mesh_crue10_run.py if not install #9

Open
nicogodet opened this issue Feb 23, 2024 · 1 comment · May be fixed by #11
Open

Make GDAL dependency optionnal and raise error in mesh_crue10_run.py if not install #9

nicogodet opened this issue Feb 23, 2024 · 1 comment · May be fixed by #11

Comments

@nicogodet
Copy link
Contributor

GDAL can be very painfull to install (especially on windows without conda...).

As mesh_crue10_run.py is the only script that depends on GDAL when a specific argument is provided, I suggest to remove GDAL from requierements.txt and raise an error if args.infile_dem is provided and GDAL is not available.

If this is OK, I can create a PR.

@lucduron
Copy link
Member

Ok if you want, although it should also be a dependency of PyTelTools (for a single script also).
I would keep it in .github/workflows/pythonpackage.yml.

I am also aware that import gdal has been replaced by from osgeo import gdal (see
https://github.com/OSGeo/gdal/blob/v3.2.1/gdal/NEWS), it should be updated.

On Windows, you can consider WinPython, it includes GDAL.

@nicogodet nicogodet linked a pull request Mar 19, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants