Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Pip package manager tests fail on Windows #159

Open
zachcran opened this issue Sep 4, 2024 · 0 comments
Open

[BUG] Pip package manager tests fail on Windows #159

zachcran opened this issue Sep 4, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@zachcran
Copy link
Contributor

zachcran commented Sep 4, 2024

Describe the bug
The pip testing (tests/cmake/package_managers/pip/test_pip.cmake) assumes that the Python venv is set up on Linux, with the Linux venv paths hard-coded. This causes the pip tests to fail on Windows.

Expected behavior
The tests should be platform agnostic, or at least support Windows, Mac, and Linux, and pass on all platforms.

Additional context
On Windows, the <venv>/bin/ directory is replaced with <venv>/Scripts/ (case insensitive). Additionally, python3 is no longer an executable in <venv>/Scripts/, with only python.exe provided (will respond to just python). Oddly, pip.exe, pip3.exe, and pip3.<minor_version>.exe are still all there.

@zachcran zachcran added the bug Something isn't working label Sep 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant