Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor PackageManagers #144

Open
ryanmrichard opened this issue Dec 20, 2023 · 0 comments
Open

Refactor PackageManagers #144

ryanmrichard opened this issue Dec 20, 2023 · 0 comments
Labels
enhancement New feature or request

Comments

@ryanmrichard
Copy link
Collaborator

Right now the PackageManger API is comprised of three members:

  • find_installed,
  • get_package, and
  • install_package

In both the CMakePackageManager and the PIPPackageManger the find_installed looks for an already installed package, returning nothing if it's not found. get_package for CMakePackageManager will call FetchContent whereas get_package for PIPPackageManager wraps find_installed and raises an error if the package is not already installed. CMakePackageManger implements install_package by wrapping CMake's install commands whereas PIPPackageManager wraps pip's install command. The package managers should be implemented in a consistent manner (probably want to change the behavior of the PIPPackageManager to be more like the CMakePackageManager).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant