Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invalid Condition in BH controller #45

Open
Arash1381-y opened this issue May 10, 2024 · 0 comments
Open

Invalid Condition in BH controller #45

Arash1381-y opened this issue May 10, 2024 · 0 comments

Comments

@Arash1381-y
Copy link

Arash1381-y commented May 10, 2024

This section of code seems weird to me: (from bh_controller)

      if (!request_found) {
        // 2.2.1    We first check the priority buffer to prioritize e.g., maintenance requests
        if (m_priority_buffer.size() != 0) {
          req_buffer = &m_priority_buffer;
          req_it = m_priority_buffer.begin();
          req_it->command = m_dram->get_preq_command(req_it->final_command, req_it->addr_vec);
          
          request_found = m_dram->check_ready(req_it->command, req_it->addr_vec);
          if (!request_found & m_priority_buffer.size() != 0) {
            return false;
          }

        if (!request_found){
           ...

        }

the last condition is a bitwise operation of the request found boolean and the size of the priority buffer which does not change from the previous condition. what is the reason behind this bitwise operation?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant