THIS CHECKLIST IS NOT COMPLETE. Use --show-ignored-findings to show all the results.
Summary
- incorrect-equality (2 results) (Medium)
- uninitialized-local (1 results) (Medium)
- unused-return (1 results) (Medium)
- shadowing-local (1 results) (Low)
- missing-zero-check (1 results) (Low)
- calls-loop (4 results) (Low)
- timestamp (5 results) (Low)
- assembly (9 results) (Informational)
- costly-loop (1 results) (Informational)
- dead-code (1 results) (Informational)
- solc-version (1 results) (Informational)
- naming-convention (56 results) (Informational)
- similar-names (3 results) (Informational)
- too-many-digits (2 results) (Informational)
Mock: not intended to be used in production
Impact: Medium Confidence: High
- ID-0 DocumentEngineMock.removeDocument(bytes32) uses a dangerous strict equality:
contracts/mocks/DocumentEngineMock.sol#L72-L89
- ID-1 DocumentEngineMock.getDocument(bytes32) uses a dangerous strict equality:
contracts/mocks/DocumentEngineMock.sol#L37-L49
The concerned variable local
mostRecentis initialized in the loop
Impact: Medium Confidence: Medium
- ID-2 SnapshotModuleBase._findScheduledMostRecentPastSnapshot().mostRecent is a local variable never initialized
contracts/modules/internal/base/SnapshotModuleBase.sol#L385
Not the case
Impact: Medium Confidence: Medium
- ID-3 DocumentModule.getDocument(bytes32) ignores return value by $._documentEngine.getDocument(_name)
contracts/modules/wrapper/extensions/DocumentModule.sol#L74-L81
Mock: not intended to be used in production
Impact: Low Confidence: High
- ID-4
IDebtEngineMock.setCreditEvents(IDebtGlobal.CreditEvents).creditEvents shadows:
- IDebtEngine.creditEvents() (function)
contracts/mocks/DebtEngineMock.sol#L7
Mock: not intended to be used in production
Impact: Low Confidence: Medium
- ID-5 AuthorizationEngineMock.authorizeAdminChange(address).newAdmin lacks a zero-check on : - nextAdmin = newAdmin
contracts/mocks/AuthorizationEngineMock.sol#L22
ValidationModuleInternal: Acknowledge
Mock: not intended to be used in production ValidationModuleInternal: the loop happens only for batch function. A relevant alternative could be the creation of a batch function for the RuleEngine, but for the moment we don't have an implemented solution.
Impact: Low Confidence: Medium
- ID-6 RuleEngineMock.messageForTransferRestriction(uint8) has external calls inside a loop: _rules[i].canReturnTransferRestrictionCode(_restrictionCode)
contracts/mocks/RuleEngine/RuleEngineMock.sol#L83-L97
- ID-7 RuleEngineMock.messageForTransferRestriction(uint8) has external calls inside a loop: _rules[i].messageForTransferRestriction(_restrictionCode)
contracts/mocks/RuleEngine/RuleEngineMock.sol#L83-L97
- ID-8 ValidationModuleInternal._operateOnTransfer(address,address,uint256) has external calls inside a loop: $._ruleEngine.operateOnTransfer(from,to,amount)
contracts/modules/internal/ValidationModuleInternal.sol#L89-L92
- ID-9 RuleEngineMock.detectTransferRestriction(address,address,uint256) has external calls inside a loop: restriction = _rules[i].detectTransferRestriction(_from,_to,_amount)
contracts/mocks/RuleEngine/RuleEngineMock.sol#L39-L59
With the Proof of Work, it was possible for a miner to modify the timestamp in a range of about 15 seconds
With the Proof Of Stake, a new block is created every 12 seconds
In all cases, we are not looking for such precision
Impact: Low Confidence: Medium
- ID-10 SnapshotModuleBase._findScheduledMostRecentPastSnapshot() uses timestamp for comparisons Dangerous comparisons:
contracts/modules/internal/base/SnapshotModuleBase.sol#L370-L398
- ID-11 DocumentEngineMock.getDocument(bytes32) uses timestamp for comparisons Dangerous comparisons:
contracts/mocks/DocumentEngineMock.sol#L37-L49
- ID-12 SnapshotModuleBase._checkTimeSnapshotAlreadyDone(uint256) uses timestamp for comparisons Dangerous comparisons:
contracts/modules/internal/base/SnapshotModuleBase.sol#L420-L424
- ID-13 SnapshotModuleBase._checkTimeInThePast(uint256) uses timestamp for comparisons Dangerous comparisons:
contracts/modules/internal/base/SnapshotModuleBase.sol#L412-L419
- ID-14 DocumentEngineMock.removeDocument(bytes32) uses timestamp for comparisons Dangerous comparisons:
contracts/mocks/DocumentEngineMock.sol#L72-L89
use to implement ERC-7201
Impact: Informational Confidence: High
- ID-15 AuthorizationModule._getAuthorizationModuleStorage() uses assembly
contracts/modules/security/AuthorizationModule.sol#L114-L118
- ID-16 EnforcementModuleInternal._getEnforcementModuleInternalStorage() uses assembly
contracts/modules/internal/EnforcementModuleInternal.sol#L112-L116
- ID-17 ValidationModuleInternal._getValidationModuleInternalStorage() uses assembly
contracts/modules/internal/ValidationModuleInternal.sol#L96-L100
- ID-18 SnapshotModuleBase._getSnapshotModuleBaseStorage() uses assembly
contracts/modules/internal/base/SnapshotModuleBase.sol#L427-L431
- ID-19 DocumentModule._getDocumentModuleStorage() uses assembly
contracts/modules/wrapper/extensions/DocumentModule.sol#L96-L100
- ID-20 PauseModule._getPauseModuleStorage() uses assembly
contracts/modules/wrapper/core/PauseModule.sol#L104-L108
- ID-21 DebtModule._getDebtModuleStorage() uses assembly
contracts/modules/wrapper/extensions/DebtModule.sol#L94-L98
- ID-22 BaseModule._getBaseModuleStorage() uses assembly
contracts/modules/wrapper/core/BaseModule.sol#L108-L112
- ID-23 ERC20BaseModule._getERC20BaseModuleStorage() uses assembly
contracts/modules/wrapper/core/ERC20BaseModule.sol#L134-L138
Acknowledge
Mocks are not destined to be used in production
Impact: Informational Confidence: Medium
- ID-24 DocumentEngineMock.removeDocument(bytes32) has costly operations inside a loop:
contracts/mocks/DocumentEngineMock.sol#L72-L89
Implemented to be gasless compatible (see MetaTxModule)
If we remove this function, we will have the following error:
"Derived contract must override function "_msgData". Two or more base classes define function with same name and parameter types."
Impact: Informational Confidence: Medium
- ID-25 CMTAT_BASE._msgData() is never used and should be removed
contracts/modules/CMTAT_BASE.sol#L232-L239
The version set in the config file is 0.8.27
Impact: Informational Confidence: High
- ID-26
Version constraint ^0.8.20 contains known severe issues (https://solidity.readthedocs.io/en/latest/bugs.html)
- VerbatimInvalidDeduplication
- FullInlinerNonExpressionSplitArgumentEvaluationOrder
- MissingSideEffectsOnSelectorAccess. It is used by:
- node_modules/@openzeppelin/contracts-upgradeable/access/AccessControlUpgradeable.sol#4
- node_modules/@openzeppelin/contracts-upgradeable/metatx/ERC2771ContextUpgradeable.sol#4
- node_modules/@openzeppelin/contracts-upgradeable/metatx/ERC2771ForwarderUpgradeable.sol#4
- node_modules/@openzeppelin/contracts-upgradeable/proxy/utils/Initializable.sol#4
- node_modules/@openzeppelin/contracts-upgradeable/proxy/utils/UUPSUpgradeable.sol#4
- node_modules/@openzeppelin/contracts-upgradeable/token/ERC20/ERC20Upgradeable.sol#4
- node_modules/@openzeppelin/contracts-upgradeable/utils/ContextUpgradeable.sol#4
- node_modules/@openzeppelin/contracts-upgradeable/utils/NoncesUpgradeable.sol#3
- node_modules/@openzeppelin/contracts-upgradeable/utils/PausableUpgradeable.sol#4
- node_modules/@openzeppelin/contracts-upgradeable/utils/cryptography/EIP712Upgradeable.sol#4
- node_modules/@openzeppelin/contracts-upgradeable/utils/introspection/ERC165Upgradeable.sol#4
- node_modules/@openzeppelin/contracts/access/AccessControl.sol#4
- node_modules/@openzeppelin/contracts/access/IAccessControl.sol#4
- node_modules/@openzeppelin/contracts/access/Ownable.sol#4
- node_modules/@openzeppelin/contracts/interfaces/IERC1967.sol#4
- node_modules/@openzeppelin/contracts/interfaces/IERC5267.sol#4
- node_modules/@openzeppelin/contracts/interfaces/draft-IERC1822.sol#4
- node_modules/@openzeppelin/contracts/interfaces/draft-IERC6093.sol#3
- node_modules/@openzeppelin/contracts/proxy/ERC1967/ERC1967Proxy.sol#4
- node_modules/@openzeppelin/contracts/proxy/ERC1967/ERC1967Utils.sol#4
- node_modules/@openzeppelin/contracts/proxy/Proxy.sol#4
- node_modules/@openzeppelin/contracts/proxy/beacon/BeaconProxy.sol#4
- node_modules/@openzeppelin/contracts/proxy/beacon/IBeacon.sol#4
- node_modules/@openzeppelin/contracts/proxy/beacon/UpgradeableBeacon.sol#4
- node_modules/@openzeppelin/contracts/proxy/transparent/ProxyAdmin.sol#4
- node_modules/@openzeppelin/contracts/proxy/transparent/TransparentUpgradeableProxy.sol#4
- node_modules/@openzeppelin/contracts/token/ERC20/IERC20.sol#4
- node_modules/@openzeppelin/contracts/token/ERC20/extensions/IERC20Metadata.sol#4
- node_modules/@openzeppelin/contracts/utils/Address.sol#4
- node_modules/@openzeppelin/contracts/utils/Arrays.sol#4
- node_modules/@openzeppelin/contracts/utils/Context.sol#4
- node_modules/@openzeppelin/contracts/utils/Create2.sol#4
- node_modules/@openzeppelin/contracts/utils/StorageSlot.sol#5
- node_modules/@openzeppelin/contracts/utils/Strings.sol#4
- node_modules/@openzeppelin/contracts/utils/cryptography/ECDSA.sol#4
- node_modules/@openzeppelin/contracts/utils/cryptography/MessageHashUtils.sol#4
- node_modules/@openzeppelin/contracts/utils/introspection/ERC165.sol#4
- node_modules/@openzeppelin/contracts/utils/introspection/IERC165.sol#4
- node_modules/@openzeppelin/contracts/utils/math/Math.sol#4
- node_modules/@openzeppelin/contracts/utils/math/SignedMath.sol#4
- contracts/CMTAT_PROXY.sol#3
- contracts/CMTAT_PROXY_UUPS.sol#3
- contracts/CMTAT_STANDALONE.sol#3
- contracts/deployment/CMTAT_BEACON_FACTORY.sol#2
- contracts/deployment/CMTAT_TP_FACTORY.sol#2
- contracts/deployment/CMTAT_UUPS_FACTORY.sol#2
- contracts/deployment/libraries/CMTATFactoryBase.sol#2
- contracts/deployment/libraries/CMTATFactoryInvariant.sol#2
- contracts/deployment/libraries/CMTATFactoryRoot.sol#2
- contracts/interfaces/ICCIPToken.sol#3
- contracts/interfaces/ICMTATConstructor.sol#2
- contracts/interfaces/ICMTATSnapshot.sol#3
- contracts/interfaces/draft-IERC1404/draft-IERC1404.sol#3
- contracts/interfaces/draft-IERC1404/draft-IERC1404EnumCode.sol#3
- contracts/interfaces/draft-IERC1404/draft-IERC1404Wrapper.sol#3
- contracts/interfaces/engine/IAuthorizationEngine.sol#3
- contracts/interfaces/engine/IDebtEngine.sol#3
- contracts/interfaces/engine/IDebtGlobal.sol#3
- contracts/interfaces/engine/IRuleEngine.sol#3
- contracts/interfaces/engine/draft-IERC1643.sol#3
- contracts/libraries/Errors.sol#3
- contracts/libraries/FactoryErrors.sol#3
- contracts/mocks/AuthorizationEngineMock.sol#3
- contracts/mocks/DebtEngineMock.sol#3
- contracts/mocks/DocumentEngineMock.sol#3
- contracts/mocks/MinimalForwarderMock.sol#3
- contracts/mocks/RuleEngine/CodeList.sol#3
- contracts/mocks/RuleEngine/RuleEngineMock.sol#3
- contracts/mocks/RuleEngine/RuleMock.sol#3
- contracts/mocks/RuleEngine/interfaces/IRule.sol#3
- contracts/mocks/RuleEngine/interfaces/IRuleEngineMock.sol#3
- contracts/modules/CMTAT_BASE.sol#3
- contracts/modules/internal/ERC20SnapshotModuleInternal.sol#3
- contracts/modules/internal/EnforcementModuleInternal.sol#3
- contracts/modules/internal/ValidationModuleInternal.sol#3
- contracts/modules/internal/base/SnapshotModuleBase.sol#3
- contracts/modules/security/AuthorizationModule.sol#3
- contracts/modules/wrapper/controllers/ValidationModule.sol#3
- contracts/modules/wrapper/core/BaseModule.sol#3
- contracts/modules/wrapper/core/ERC20BaseModule.sol#3
- contracts/modules/wrapper/core/ERC20BurnModule.sol#3
- contracts/modules/wrapper/core/ERC20MintModule.sol#3
- contracts/modules/wrapper/core/EnforcementModule.sol#3
- contracts/modules/wrapper/core/PauseModule.sol#3
- contracts/modules/wrapper/extensions/DebtModule.sol#3
- contracts/modules/wrapper/extensions/DocumentModule.sol#3
- contracts/modules/wrapper/extensions/ERC20SnapshotModule.sol#3
- contracts/modules/wrapper/extensions/MetaTxModule.sol#3
- contracts/test/proxy/CMTAT_PROXY_TEST.sol#3
- contracts/test/proxy/CMTAT_PROXY_TEST_UUPS.sol#3
It is not really necessary to rename all the variables. It will generate a lot of work for a minor improvement.
Impact: Informational Confidence: High
- ID-27 Contract CMTAT_PROXY_UUPS is not in CapWords
contracts/CMTAT_PROXY_UUPS.sol#L11-L54
- ID-28 Enum IERC1404EnumCode.REJECTED_CODE_BASE is not in CapWords
contracts/interfaces/draft-IERC1404/draft-IERC1404EnumCode.sol#L9-L14
- ID-29 Constant EnforcementModuleInternal.EnforcementModuleInternalStorageLocation is not in UPPER_CASE_WITH_UNDERSCORES
contracts/modules/internal/EnforcementModuleInternal.sol#L41
- ID-30 Function CMTATFactoryRoot.CMTATProxyAddress(uint256) is not in mixedCase
contracts/deployment/libraries/CMTATFactoryRoot.sol#L45-L47
- ID-31 Parameter RuleEngineMock.detectTransferRestriction(address,address,uint256)._amount is not in mixedCase
contracts/mocks/RuleEngine/RuleEngineMock.sol#L42
- ID-32 Constant PauseModule.PauseModuleStorageLocation is not in UPPER_CASE_WITH_UNDERSCORES
contracts/modules/wrapper/core/PauseModule.sol#L28
- ID-33 Contract CMTAT_UUPS_FACTORY is not in CapWords
contracts/deployment/CMTAT_UUPS_FACTORY.sol#L15-L93
- ID-34 Contract CMTAT_PROXY is not in CapWords
contracts/CMTAT_PROXY.sol#L11-L23
- ID-35 Function PauseModule.__PauseModule_init_unchained() is not in mixedCase
contracts/modules/wrapper/core/PauseModule.sol#L34-L36
- ID-36 Function BaseModule.__Base_init_unchained(string,string,string) is not in mixedCase
contracts/modules/wrapper/core/BaseModule.sol#L40-L49
- ID-37 Function EnforcementModuleInternal.__Enforcement_init_unchained() is not in mixedCase
contracts/modules/internal/EnforcementModuleInternal.sol#L53-L55
- ID-38 Struct CMTATFactoryInvariant.CMTAT_ARGUMENT is not in CapWords
contracts/deployment/libraries/CMTATFactoryInvariant.sol#L13-L18
- ID-39 Function ERC20BurnModule.__ERC20BurnModule_init_unchained() is not in mixedCase
contracts/modules/wrapper/core/ERC20BurnModule.sol#L32-L34
- ID-40 Function ValidationModuleInternal.__Validation_init_unchained(IRuleEngine) is not in mixedCase
contracts/modules/internal/ValidationModuleInternal.sol#L30-L38
- ID-41 Constant ValidationModuleInternal.ValidationModuleInternalStorageLocation is not in UPPER_CASE_WITH_UNDERSCORES
contracts/modules/internal/ValidationModuleInternal.sol#L24
- ID-42 Contract CMTAT_STANDALONE is not in CapWords
contracts/CMTAT_STANDALONE.sol#L11-L37
- ID-43 Parameter RuleEngineMock.operateOnTransfer(address,address,uint256)._to is not in mixedCase
contracts/mocks/RuleEngine/RuleEngineMock.sol#L74
- ID-44 Parameter RuleEngineMock.validateTransfer(address,address,uint256)._amount is not in mixedCase
contracts/mocks/RuleEngine/RuleEngineMock.sol#L64
- ID-45 Parameter RuleEngineMock.operateOnTransfer(address,address,uint256)._from is not in mixedCase
contracts/mocks/RuleEngine/RuleEngineMock.sol#L73
- ID-46 Parameter RuleMock.validateTransfer(address,address,uint256)._to is not in mixedCase
contracts/mocks/RuleEngine/RuleMock.sol#L15
- ID-47 Parameter RuleEngineMock.operateOnTransfer(address,address,uint256)._amount is not in mixedCase
contracts/mocks/RuleEngine/RuleEngineMock.sol#L75
- ID-48 Parameter RuleMock.canReturnTransferRestrictionCode(uint8)._restrictionCode is not in mixedCase
contracts/mocks/RuleEngine/RuleMock.sol#L36
- ID-49 Function DebtModule.__DebtModule_init_unchained(IDebtEngine) is not in mixedCase
contracts/modules/wrapper/extensions/DebtModule.sol#L41-L50
- ID-50 Parameter RuleEngineMock.validateTransfer(address,address,uint256)._to is not in mixedCase
contracts/mocks/RuleEngine/RuleEngineMock.sol#L63
- ID-51 Function DocumentModule.__DocumentModule_init_unchained(IERC1643) is not in mixedCase
contracts/modules/wrapper/extensions/DocumentModule.sol#L41-L48
- ID-52 Parameter DocumentModule.getDocument(bytes32)._name is not in mixedCase
contracts/modules/wrapper/extensions/DocumentModule.sol#L74
- ID-53 Constant SnapshotModuleBase.SnapshotModuleBaseStorageLocation is not in UPPER_CASE_WITH_UNDERSCORES
contracts/modules/internal/base/SnapshotModuleBase.sol#L45
- ID-54 Function AuthorizationModule.__AuthorizationModule_init_unchained(address,IAuthorizationEngine) is not in mixedCase
contracts/modules/security/AuthorizationModule.sol#L30-L41
- ID-55 Function CMTAT_BASE.__CMTAT_init(address,ICMTATConstructor.ERC20Attributes,ICMTATConstructor.BaseModuleAttributes,ICMTATConstructor.Engine) is not in mixedCase
contracts/modules/CMTAT_BASE.sol#L77-L129
- ID-56 Constant ERC20BaseModule.ERC20BaseModuleStorageLocation is not in UPPER_CASE_WITH_UNDERSCORES
contracts/modules/wrapper/core/ERC20BaseModule.sol#L26
- ID-57 Parameter RuleEngineMock.validateTransfer(address,address,uint256)._from is not in mixedCase
contracts/mocks/RuleEngine/RuleEngineMock.sol#L62
- ID-58 Parameter RuleMock.validateTransfer(address,address,uint256)._amount is not in mixedCase
contracts/mocks/RuleEngine/RuleMock.sol#L16
- ID-59 Parameter CMTAT_PROXY_UUPS.initialize(address,ICMTATConstructor.ERC20Attributes,ICMTATConstructor.BaseModuleAttributes,ICMTATConstructor.Engine).ERC20Attributes_ is not in mixedCase
contracts/CMTAT_PROXY_UUPS.sol#L39
- ID-60 Parameter CMTAT_BASE.initialize(address,ICMTATConstructor.ERC20Attributes,ICMTATConstructor.BaseModuleAttributes,ICMTATConstructor.Engine).ERC20Attributes_ is not in mixedCase
contracts/modules/CMTAT_BASE.sol#L61
- ID-61 Function CMTAT_BASE.__CMTAT_init_unchained() is not in mixedCase
contracts/modules/CMTAT_BASE.sol#L131-L133
- ID-62 Constant DocumentModule.DocumentModuleStorageLocation is not in UPPER_CASE_WITH_UNDERSCORES
contracts/modules/wrapper/extensions/DocumentModule.sol#L27
- ID-63 Parameter RuleMock.detectTransferRestriction(address,address,uint256)._amount is not in mixedCase
contracts/mocks/RuleEngine/RuleMock.sol#L27
- ID-64 Function ERC20BaseModule.__ERC20BaseModule_init_unchained(uint8) is not in mixedCase
contracts/modules/wrapper/core/ERC20BaseModule.sol#L39-L44
- ID-65 Parameter RuleMock.messageForTransferRestriction(uint8)._restrictionCode is not in mixedCase
contracts/mocks/RuleEngine/RuleMock.sol#L42
- ID-66 Constant AuthorizationModule.AuthorizationModuleStorageLocation is not in UPPER_CASE_WITH_UNDERSCORES
contracts/modules/security/AuthorizationModule.sol#L17
- ID-67 Function ERC20MintModule.__ERC20MintModule_init_unchained() is not in mixedCase
contracts/modules/wrapper/core/ERC20MintModule.sol#L27-L29
- ID-68 Parameter RuleEngineMock.detectTransferRestriction(address,address,uint256)._to is not in mixedCase
contracts/mocks/RuleEngine/RuleEngineMock.sol#L41
- ID-69 Constant BaseModule.BaseModuleStorageLocation is not in UPPER_CASE_WITH_UNDERSCORES
contracts/modules/wrapper/core/BaseModule.sol#L25
- ID-70 Function SnapshotModuleBase.__SnapshotModuleBase_init_unchained() is not in mixedCase
contracts/modules/internal/base/SnapshotModuleBase.sol#L70-L73
- ID-71 Contract CMTAT_BEACON_FACTORY is not in CapWords
contracts/deployment/CMTAT_BEACON_FACTORY.sol#L15-L110
- ID-72 Parameter CMTAT_BASE._CMTAT_init(address,ICMTATConstructor.ERC20Attributes,ICMTATConstructor.BaseModuleAttributes,ICMTATConstructor.Engine).ERC20Attributes is not in mixedCase
contracts/modules/CMTAT_BASE.sol#L79
- ID-73 Contract CMTAT_BASE is not in CapWords
contracts/modules/CMTAT_BASE.sol#L29-L240
- ID-74 Parameter RuleEngineMock.messageForTransferRestriction(uint8)._restrictionCode is not in mixedCase
contracts/mocks/RuleEngine/RuleEngineMock.sol#L84
- ID-75 Function ValidationModule.__ValidationModule_init_unchained() is not in mixedCase
contracts/modules/wrapper/controllers/ValidationModule.sol#L28-L30
- ID-76 Parameter RuleEngineMock.detectTransferRestriction(address,address,uint256)._from is not in mixedCase
contracts/mocks/RuleEngine/RuleEngineMock.sol#L40
- ID-77 Constant DebtModule.DebtModuleStorageLocation is not in UPPER_CASE_WITH_UNDERSCORES
contracts/modules/wrapper/extensions/DebtModule.sol#L20
- ID-78 Function ERC20SnapshotModule.__ERC20SnasphotModule_init_unchained() is not in mixedCase
contracts/modules/wrapper/extensions/ERC20SnapshotModule.sol#L22-L24
- ID-79 Function EnforcementModule.__EnforcementModule_init_unchained() is not in mixedCase
contracts/modules/wrapper/core/EnforcementModule.sol#L27-L29
- ID-80 Function ERC20SnapshotModuleInternal.__ERC20Snapshot_init_unchained() is not in mixedCase
contracts/modules/internal/ERC20SnapshotModuleInternal.sol#L21-L24
- ID-81 Contract CMTAT_TP_FACTORY is not in CapWords
contracts/deployment/CMTAT_TP_FACTORY.sol#L15-L98
- ID-82 Parameter RuleMock.validateTransfer(address,address,uint256)._from is not in mixedCase
contracts/mocks/RuleEngine/RuleMock.sol#L14
Acknowledge
Impact: Informational Confidence: Medium
- ID-83 Variable IERC1643Whole.setDocument(bytes32,string,bytes32)._documentHash is too similar to DocumentEngineMock.setDocument(bytes32,string,bytes32).documentHash_
contracts/mocks/DocumentEngineMock.sol#L8
- ID-84 Variable CMTAT_BEACON_FACTORY._getBytecode(CMTATFactoryInvariant.CMTAT_ARGUMENT)._implementation is too similar to CMTAT_BEACON_FACTORY.constructor(address,address,address,bool).implementation_
contracts/deployment/CMTAT_BEACON_FACTORY.sol#L100-L106
- ID-85 Variable DebtEngineMock._creditEvents is too similar to DebtEngineMock.setCreditEvents(IDebtGlobal.CreditEvents).creditEvents_
contracts/mocks/DebtEngineMock.sol#L15
Don't understand
Impact: Informational Confidence: Medium
- ID-86 CMTAT_TP_FACTORY._getBytecode(address,CMTATFactoryInvariant.CMTAT_ARGUMENT) uses literals with too many digits:
contracts/deployment/CMTAT_TP_FACTORY.sol#L85-L96
- ID-87 CMTAT_BEACON_FACTORY._getBytecode(CMTATFactoryInvariant.CMTAT_ARGUMENT) uses literals with too many digits:
contracts/deployment/CMTAT_BEACON_FACTORY.sol#L97-L108