spawn/Prepared: pass std::string_view to SetEnv()

CM4all · Oct 23, 2023 · 389596e · 389596e
1 parent 719f80c
commit 389596e
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 4 deletions.
diff --git a/src/spawn/Prepared.cxx b/src/spawn/Prepared.cxx
@@ -36,10 +36,9 @@ PreparedChildProcess::InsertWrapper(std::span<const char *const> w) noexcept
 }
 
 void
-PreparedChildProcess::SetEnv(const char *name, const char *value) noexcept
+PreparedChildProcess::SetEnv(std::string_view name, std::string_view value) noexcept
 {
-	assert(name != nullptr);
-	assert(value != nullptr);
+	assert(!name.empty());
 
 	strings.emplace_front(name);
 	auto &s = strings.front();

diff --git a/src/spawn/Prepared.hxx b/src/spawn/Prepared.hxx
@@ -170,7 +170,7 @@ struct PreparedChildProcess {
 		env.push_back(p);
 	}
 
-	void SetEnv(const char *name, const char *value) noexcept;
+	void SetEnv(std::string_view name, std::string_view value) noexcept;
 
 	const char *GetEnv(std::string_view name) const noexcept;