Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Neogit/syntax and hl.lua changes result in highlight regression #45

Closed
wroyca opened this issue Jun 26, 2023 · 1 comment
Closed

Neogit/syntax and hl.lua changes result in highlight regression #45

wroyca opened this issue Jun 26, 2023 · 1 comment
Labels
bug Something isn't working

Comments

@wroyca
Copy link

wroyca commented Jun 26, 2023

Description

The recent modifications made in 448f660 accidentally broke Neogit's highlights, often resulting in incorrect highlights or, if you are to change colorscheme, no highlights appearing at all

See also echasnovski/mini.nvim#388

Neovim version

NVIM v0.9.1
Build type: RelWithDebInfo
LuaJIT 2.1.0-beta3

Operating system and version

Fedora 38

Steps to reproduce

  1. Select any commit to open the commit-view
  2. Look at signs highlights
  3. Change colorscheme from cmdline

Expected behavior

image

Actual behavior

image

image

Minimal config

vim.cmd([[set runtimepath=$VIMRUNTIME]])
vim.cmd([[set packpath=/tmp/nvim/site]])
local package_root = "/tmp/nvim/site/pack"
local install_path = package_root .. "/packer/start/packer.nvim"
local function load_plugins()
  require("packer").startup({
    {
      "wbthomason/packer.nvim",
      {
        "TimUntersberger/neogit",
        requires = {
          { "nvim-lua/plenary.nvim" },
          { "sindrets/diffview.nvim" },
        },
        config = function()
          print("loaded neogit")
          require("neogit").setup()
        end,
      },
    },
    config = {
      package_root = package_root,
      compile_path = install_path .. "/plugin/packer_compiled.lua",
      display = { non_interactive = true },
    },
  })
end
if vim.fn.isdirectory(install_path) == 0 then
  print("Installing neogit and dependencies.")
  vim.fn.system({ "git", "clone", "--depth=1", "https://github.com/wbthomason/packer.nvim", install_path })
end
load_plugins()
require("packer").sync()
@wroyca
Copy link
Author

wroyca commented Oct 7, 2023

Should be properly handled with NeogitOrg#617

@wroyca wroyca closed this as completed Oct 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant