-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
VDIF Handling Updates #49
Merged
bwmeyers
merged 9 commits into
CIRA-Pulsars-and-Transients-Group:main
from
cplee1:vdif_fix
Jun 6, 2024
Merged
VDIF Handling Updates #49
bwmeyers
merged 9 commits into
CIRA-Pulsars-and-Transients-Group:main
from
cplee1:vdif_fix
Jun 6, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Re-added 'nchunks' option to divide up the data into chunks to fit onto gpu - Added NPOL to VDIF header
- The calculation of file_no (to decide which half of the buffer to fill) had been moved to a spot after one of the dependent values had changed. The way this is calculated has now been changed.
…e to be less confusing
bwmeyers
approved these changes
Jun 6, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay, this looks good to me. I see you removed the UTC_START
keyword from the VDIF header, as discussed. Assuming all this is tested at some level (which I think it has been based on the plots shown here and offline), will merge it into the main branch ASAP!
bwmeyers
merged commit Jun 6, 2024
eb170b2
into
CIRA-Pulsars-and-Transients-Group:main
1 check passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A few updates to the VDIF handing and writing. The code has been compiled and tested on Garrawarla, and the output has been tested using DSPSR and CDMT/prepfold. The bug fix does not appear to fix the issues with pulse broadening at short time scales (#45), but it does fix and issue I was having in CDMT where there were artefacts appearing every 1 second (after passing through the convolving filterbank).
Updates from @robotopia:
7522697
: Adding back in the-n
option to the beamformer to chunk the processing.f0433e7
: Fixed bug where the first second of VDIF data was all zeros. This addresses Investigate/Fix empty output for first second of VDIF data #26.Updates from @cplee1:
99f8c2a
/4242a19
: Updated the ASCII header file which gets written for each VDIF file. Now includes NPOL (a new requirement in DSPSR) and some of the VDIF packet header info (for convenience/debugging and human readability). This addresses Improve VDIF ASCII header text to better represent the output #47.ca32e97
: Flattened the multi-dimensional arraydetected_beam
containing the fine-channelised beamformed voltages, and renamed it todata_buffer_fine
so that it's not confused with a buffer containing detected output.Example 1: Below is the beginning of the detected timeseries at a time resolution of 12.5 us, after dedispersing to zero DM. Instead of 1 full second of zeros, there is only ~1.5 ms of invalid data. This is where the PFB hits the edge of the data.
Example 2: Below is a coherently dedispersed detection of J0437-4715, from cdmt/prepfold and from dspsr/pdmp. The profile still looks smeared - even more smeared than the incoherently dedispersed profile in Bhat et al. 2018.
Example 3: The new ASCII header file format.