Fix config caching in vmCalcB
#60
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In original version, all of configs[NCONFIGS] point to tempJones, which is apparently not expected behaviour for caching configs. This implementation allocates new memory for each config. Signed-off-by: fxzjshm <[email protected]>
|
Okay. I have changed the base of this PR to a new branch for testing the solution so that it doesn't affect the current |
bwmeyers
merged commit e506d34
into
CIRA-Pulsars-and-Transients-Group:fix-config-mismatch
1 check passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In original version, all of configs[NCONFIGS] point to tempJones, which is apparently not expected behaviour for caching configs. This implementation allocates new memory for each config.
Hopefully fixes: #59