Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Eval System tests. #27

Open
joaquinffernandez opened this issue Mar 18, 2024 · 2 comments
Open

Fix Eval System tests. #27

joaquinffernandez opened this issue Mar 18, 2024 · 2 comments
Assignees
Labels
bug Something isn't working enhancement New feature or request

Comments

@joaquinffernandez
Copy link
Collaborator

Currently disable pw_map and map eval system tests because they are failing consistently. Either fix or update them so we can add them back to the test-suite.

@joaquinffernandez joaquinffernandez added bug Something isn't working enhancement New feature or request labels Mar 18, 2024
@Kalashnikovni Kalashnikovni moved this from Backlog to To do in SB-Graph library issue tracker. Oct 9, 2024
@Kalashnikovni Kalashnikovni self-assigned this Oct 9, 2024
@Kalashnikovni Kalashnikovni added this to the SB-Graph 3.0.0 milestone Oct 9, 2024
@Kalashnikovni Kalashnikovni moved this from To do to In progress in SB-Graph library issue tracker. Oct 9, 2024
@Kalashnikovni Kalashnikovni removed this from the SB-Graph 3.0.0 milestone Oct 9, 2024
@Kalashnikovni Kalashnikovni added this to the SB-Graph 4.0.0 milestone Jan 15, 2025
@Kalashnikovni
Copy link
Collaborator

Together with this error it was detected that some tests failed while working with SBGs with empty sets of edges, such as:

N = 10

V1 = N

matchSCCTS(
  V %= {[1:1:V1]};
  Vmap %= <<{[1:1:V1]} -> 0*x+1>>; 
  map1 %= <<>>;
  map2 %= <<>>;
  Emap %= <<>>;
, 1
)

@Kalashnikovni
Copy link
Collaborator

After fixing the previous issue in the SBGraph::copy operation that didn't handle empty SBGs, executing the above test resulted in SEGFAULT, thus a run with GDB indicated:

#2 0x000055555567456c in SBG::LIB::SBGTopSortSBG::LIB::OrdPWMDInter::calculate (this=this@entry=0x7fffffffa210) at sbg/sbg_algorithms.cpp:697

which again was due to lack of handling of SBGs with empty sets of vertices.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
Development

No branches or pull requests

2 participants