Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Datacleaning example does not provide adequate user feedback nor usage information #251

Open
QUARK88 opened this issue Jul 19, 2021 · 1 comment

Comments

@QUARK88
Copy link

QUARK88 commented Jul 19, 2021

No output from the data cleaning [when used on 20170529_111858_VWFS Deneb_PDS.s7k]

@QUARK88 QUARK88 closed this as completed Jul 19, 2021
@glabmoris
Copy link
Contributor

glabmoris commented Jul 22, 2021

After testing, this was due to the complete lack of feedback from the application, which was very misleading to the end user. To solve this issue, we need to add the following features to the data-cleaning executable:

  1. When starting, the program should display "Reading georeferenced data from standard input" on the standard error output (stderr....it can either use classic C's fprintf() function or C++'s std::cerr)

  2. When not passing any parameters through the command line, it should exit and display a small usage information notice on the standard error output such as:

Usage: data-cleaning [-q minimum quality factor] [-i minimum intensity value]

@QUARK88 code this and submit a pull request referencing this issue

@glabmoris glabmoris reopened this Jul 22, 2021
@glabmoris glabmoris changed the title Datacleaning does not work on 20170529_111858_VWFS Deneb_PDS.s7k Datacleaning example does not provide adequate user feedback nor usage information Jul 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants