Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MizuRoute compile flags outdated #169

Open
wknoben opened this issue Feb 22, 2024 · 1 comment
Open

MizuRoute compile flags outdated #169

wknoben opened this issue Feb 22, 2024 · 1 comment
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@wknoben
Copy link
Collaborator

wknoben commented Feb 22, 2024

make -f ${F_MASTER}/build/Makefile FC=$FC FC_EXE=$FC_EXE EXE=$EXE MODE=$MODE isOpenMP=$isOpenMP F_MASTER=$F_MASTER NCDF_PATH=$NCDF_PATH FLAGS="$FLAGS"

Flags here were hard-coded for traceability:

FLAGS="-O3 -ffree-line-length-none -fmax-errors=0 ${FLAGS_OMP}"

Expected inputs for mizuRoute have changed (version v1.2.3, branch description main-0-g0a62ee6, hash 0a62ee6185bdc9b99cd88ed5f15ea850602c43a2). Example ("fast" mode):

FLAGS = -O3 -fmax-errors=0 -ffree-line-length-none $(FLAGS_OMP) -cpp -DVERSION=\"$(VERSION)\" -DBRANCH=\"$(GITBRCH)\" -DHASH=\"$(GITHASH)\"

Adding the new part

cpp -DVERSION=\"$(VERSION)\" -DBRANCH=\"$(GITBRCH)\" -DHASH=\"$(GITHASH)\"

to the script here might resolve this issue.

@wknoben wknoben added bug Something isn't working good first issue Good for newcomers labels Feb 22, 2024
@wknoben
Copy link
Collaborator Author

wknoben commented Feb 23, 2024

Apparently this doesn't work as suggested. Simply removing the flag specification from 2a_compile_mizuroute.sh and relying on the logic inside mizuRoute's makefile to set the correct flags is probably better.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant