-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CORE: Use boost::multiprecision::number API #6035
Conversation
There are currently still several |
I am wondering if we can remove this file with the functions that serialize the various CORE types. This is not documented. |
Since I see "Still under constructions" in the comments, I'd remove it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
With Sébastien
Co-authored-by: Marc Glisse <[email protected]>
follow the code rather than the doc...
try to workaround compilation issue on windows
Successfully tested in CGAL-6.0-Ic-200 |
Is this pull-request (marked Tested ) still a work-in-progress, or can it be merged? |
This pull-request was previously marked with the label |
It can be merged now. |
Summary of Changes
Currently CGAL_Core uses the low level API of GMP for
BigInt
andBigRat
. In this PR I replace this with theboost::multiprecision::number
API, so that we can easily switch between the GMP and the cpp backends.Release Management
TODO: