Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CORE: Use boost::multiprecision::number API #6035

Merged
merged 144 commits into from
Mar 26, 2024

Conversation

afabri
Copy link
Member

@afabri afabri commented Oct 7, 2021

Summary of Changes

Currently CGAL_Core uses the low level API of GMP for BigInt and BigRat. In this PR I replace this with the boost::multiprecision::number API, so that we can easily switch between the GMP and the cpp backends.

Release Management

  • Affected package(s): CGAL_Core
  • Issue(s) solved (if any): fix #0000, fix #0000,...
  • Feature/Small Feature (if any):
  • Link to compiled documentation (obligatory for small feature) wrong link name to be changed
  • License and copyright ownership:

TODO:

  • document Boost 1.70 is required.
  • Announce (CHANGES.md) the boost version bump

@afabri afabri added this to the 5.5-beta1 milestone Oct 7, 2021
@afabri
Copy link
Member Author

afabri commented Oct 7, 2021

There are currently still several assert(false) where I have to rewrite code. And several comments starting with AF:.

CGAL_Core/include/CGAL/CORE/BigInt.h Outdated Show resolved Hide resolved
CGAL_Core/include/CGAL/CORE/BigInt.h Outdated Show resolved Hide resolved
CGAL_Core/include/CGAL/CORE/BigInt.h Outdated Show resolved Hide resolved
CGAL_Core/include/CGAL/CORE/BigInt.h Outdated Show resolved Hide resolved
CGAL_Core/include/CGAL/CORE/BigRat.h Outdated Show resolved Hide resolved
CGAL_Core/include/CGAL/CORE/BigRat.h Outdated Show resolved Hide resolved
CGAL_Core/include/CGAL/CORE/BigRat.h Outdated Show resolved Hide resolved
CGAL_Core/include/CGAL/CORE/BigRat.h Outdated Show resolved Hide resolved
CGAL_Core/include/CGAL/CORE/BigRat.h Outdated Show resolved Hide resolved
CGAL_Core/include/CGAL/CORE/BigRat.h Outdated Show resolved Hide resolved
@afabri
Copy link
Member Author

afabri commented Oct 12, 2021

I am wondering if we can remove this file with the functions that serialize the various CORE types. This is not documented.

@afabri afabri marked this pull request as ready for review October 12, 2021 16:00
@sloriot
Copy link
Member

sloriot commented Oct 13, 2021

Since I see "Still under constructions" in the comments, I'd remove it.

Copy link
Member

@mglisse mglisse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With Sébastien

CGAL_Core/include/CGAL/CORE/BigInt.h Outdated Show resolved Hide resolved
CGAL_Core/include/CGAL/CORE/BigInt.h Outdated Show resolved Hide resolved
CGAL_Core/include/CGAL/CORE/BigInt.h Outdated Show resolved Hide resolved
CGAL_Core/include/CGAL/CORE/BigInt.h Outdated Show resolved Hide resolved
CGAL_Core/include/CGAL/CORE/BigInt.h Outdated Show resolved Hide resolved
CGAL_Core/include/CGAL/CORE/BigInt.h Outdated Show resolved Hide resolved
@sloriot sloriot modified the milestones: 5.5-beta, 5.6-beta May 9, 2022
Co-authored-by: Marc Glisse <[email protected]>
@sloriot
Copy link
Member

sloriot commented Mar 25, 2024

Successfully tested in CGAL-6.0-Ic-200

@lrineau
Copy link
Member

lrineau commented Mar 25, 2024

Is this pull-request (marked Tested ) still a work-in-progress, or can it be merged?

@github-actions github-actions bot removed the Tested label Mar 25, 2024
Copy link

This pull-request was previously marked with the label Tested, but has been modified with new commits. That label has been removed.

@sloriot sloriot added the Tested label Mar 25, 2024
@sloriot
Copy link
Member

sloriot commented Mar 25, 2024

It can be merged now.

@lrineau lrineau changed the title CORE: Use boost::multiprecision::number API (WIP) CORE: Use boost::multiprecision::number API Mar 26, 2024
@lrineau lrineau merged commit 54c5d19 into CGAL:master Mar 26, 2024
8 of 9 checks passed
@lrineau lrineau deleted the CORE-boost_mp_number-GF branch March 26, 2024 09:06
@lrineau lrineau self-assigned this Mar 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants