Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Weird global state, possibly left over test code? #459

Open
kubagalecki opened this issue Nov 1, 2023 · 1 comment
Open

Weird global state, possibly left over test code? #459

kubagalecki opened this issue Nov 1, 2023 · 1 comment

Comments

@kubagalecki
Copy link
Contributor

@llaniewski Can we get rid of this? It seems like xml_def is only used in the geometry stuff, can I confine it to that part?

if (xml_def_init()) { error("Error in xml_def_init. It should work!\n"); return -1; }

@llaniewski
Copy link
Member

llaniewski commented Nov 1, 2023

I think you can move it now, and later I can get rid of it entirely. It doesn't really do much and what it does can be solved differently.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants