Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce consistent mechanics for handling NAN #396

Open
llaniewski opened this issue May 17, 2022 · 0 comments
Open

Introduce consistent mechanics for handling NAN #396

llaniewski opened this issue May 17, 2022 · 0 comments
Assignees
Labels
enhancement New features/updates

Comments

@llaniewski
Copy link
Member

llaniewski commented May 17, 2022

The current mechanics of Failcheck is cumbersome and not easy to extend. There are several places in the code (eg. Globals, DEM forces, different outputs) where code can cheaply check for NAN's, but here is no way to handle them.

We could introduce an element:

<OnNAN>
<VTK Iterations="1"/>
<Solver Iterations="10"/>
</OnNAN>

Which would register handlers, that the rest of the code can use in case of emergencies.

That could describe what you want to do when we see NAN anywhere. It could even have stuff like ignoreGlobals="true" to have more control. Failcheck would be still there, but the only function of it would be to explicitly check for NAN's in the domain.

FYI: @TravisMitchell

@llaniewski llaniewski added the enhancement New features/updates label May 17, 2022
@llaniewski llaniewski self-assigned this May 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New features/updates
Projects
None yet
Development

No branches or pull requests

1 participant