Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect units should cause an error #342

Open
wattrg opened this issue Jan 4, 2021 · 0 comments
Open

Incorrect units should cause an error #342

wattrg opened this issue Jan 4, 2021 · 0 comments
Assignees
Labels

Comments

@wattrg
Copy link

wattrg commented Jan 4, 2021

Currently if incorrect units are specified for Quantities, the code will proceed without warning/error, however it will output nonsense to the output files. For example, adding
AddQuantity(name="mu", unit="H/m", comment="magnetic permeability")
to Dynamics.R won't cause any errors, but the values of mu which are outputted won't be correct because "H" is not a valid unit.

Instead a warning or error should be given saying that an invalid unit has been specified.

@llaniewski llaniewski added the bug label May 10, 2021
@llaniewski llaniewski self-assigned this May 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants